mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org,
	Jason Wessel <jason.wessel@windriver.com>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Douglas Anderson <dianders@chromium.org>,
	Aaron Tomlin <atomlin@atomlin.com>,
	kgdb-bugreport@lists.sourceforge.net
Subject: [PATCH printk v2 1/5] kdb: do not assume write() callback available
Date: Mon, 10 Jul 2023 15:51:20 +0206	[thread overview]
Message-ID: <20230710134524.25232-2-john.ogness@linutronix.de> (raw)
In-Reply-To: <20230710134524.25232-1-john.ogness@linutronix.de>

It is allowed for consoles to provide no write() callback. For
example ttynull does this.

Check if a write() callback is available before using it.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
---
 kernel/debug/kdb/kdb_io.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
index 5c7e9ba7cd6b..e9139dfc1f0a 100644
--- a/kernel/debug/kdb/kdb_io.c
+++ b/kernel/debug/kdb/kdb_io.c
@@ -576,6 +576,8 @@ static void kdb_msg_write(const char *msg, int msg_len)
 			continue;
 		if (c == dbg_io_ops->cons)
 			continue;
+		if (!c->write)
+			continue;
 		/*
 		 * Set oops_in_progress to encourage the console drivers to
 		 * disregard their internal spin locks: in the current calling
-- 
2.30.2


  reply	other threads:[~2023-07-10 13:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10 13:45 [PATCH printk v2 0/5] various cleanups John Ogness
2023-07-10 13:45 ` John Ogness [this message]
2023-07-11  0:25   ` [PATCH printk v2 1/5] kdb: do not assume write() callback available Sergey Senozhatsky
2023-07-11  8:23   ` Daniel Thompson
2023-07-11  8:58     ` John Ogness
2023-07-11  9:01       ` Daniel Thompson
2023-07-10 13:45 ` [PATCH printk v2 2/5] printk: Add NMI safety to console_flush_on_panic() and console_unblank() John Ogness
2023-07-11 15:43   ` Petr Mladek
2023-07-11 16:07     ` Sergey Senozhatsky
2023-07-12 21:11     ` John Ogness
2023-07-13 14:43       ` Petr Mladek
2023-07-14  4:00         ` Sergey Senozhatsky
2023-07-14  9:41           ` Petr Mladek
2023-07-10 13:45 ` [PATCH printk v2 3/5] printk: Consolidate console deferred printing John Ogness
2023-07-11 15:17   ` Sergey Senozhatsky
2023-07-13 14:51   ` Petr Mladek
2023-07-10 13:45 ` [PATCH printk v2 4/5] printk: Add per-console suspended state John Ogness
2023-07-11 15:08   ` Sergey Senozhatsky
2023-07-11 15:23     ` John Ogness
2023-07-11 15:26       ` Sergey Senozhatsky
2023-07-11 15:30   ` Sergey Senozhatsky
2023-07-13 15:53   ` Petr Mladek
2023-07-10 13:45 ` [PATCH printk v2 5/5] printk: Rename abandon_console_lock_in_panic() to other_cpu_in_panic() John Ogness
2023-07-11  0:22   ` Sergey Senozhatsky
2023-07-13 15:55   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230710134524.25232-2-john.ogness@linutronix.de \
    --to=john.ogness@linutronix.de \
    --cc=atomlin@atomlin.com \
    --cc=daniel.thompson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=jason.wessel@windriver.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®