From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A73E9C001B0 for ; Mon, 10 Jul 2023 16:36:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230038AbjGJQgN (ORCPT ); Mon, 10 Jul 2023 12:36:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbjGJQgM (ORCPT ); Mon, 10 Jul 2023 12:36:12 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 736C8120; Mon, 10 Jul 2023 09:36:10 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 21C0D223A4; Mon, 10 Jul 2023 16:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689006969; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2sfvjB1A0AwpI2PjUSmQqejHy2/OmMjxbXGDG72naLk=; b=GEK+HflRi+8JRKXTGL4bcon//yAy5Xaor34VtkrcUwUihWquru0JnCG4Vu0xxgqVaq2fg9 WxPHdp43SP/IJbJVub65YX01wcWv5lVQNq2xP0ijAsPiFsbJsl0PT6TJQrnQXwc6FJ8GJ1 dQaY8sNALWhmC5dz/HI2NDZ0kQJCpCM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689006969; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2sfvjB1A0AwpI2PjUSmQqejHy2/OmMjxbXGDG72naLk=; b=9VrmsvD/Z4OdIWNqzeHAomfyR/ln8VG8+XfSo0NbCYtcifnCwQLKnBGFaAV4Z9yp4gDW75 WIc6murT70bi0tAA== Received: from kitsune.suse.cz (kitsune.suse.cz [10.100.12.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id EB2542C142; Mon, 10 Jul 2023 16:36:08 +0000 (UTC) Date: Mon, 10 Jul 2023 18:36:07 +0200 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Cyril Brulebois Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , Rob Herring , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] fbdev/offb: Update expected device name Message-ID: <20230710163607.GZ9196@kitsune.suse.cz> References: <20230412095509.2196162-1-cyril@debamax.com> <20230412095509.2196162-2-cyril@debamax.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230412095509.2196162-2-cyril@debamax.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 12, 2023 at 11:55:08AM +0200, Cyril Brulebois wrote: > Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), > as spotted by Frédéric Bonnard, the historical "of-display" device is > gone: the updated logic creates "of-display.0" instead, then as many > "of-display.N" as required. > > This means that offb no longer finds the expected device, which prevents > the Debian Installer from setting up its interface, at least on ppc64el. > > It might be better to iterate on all possible nodes, but updating the > hardcoded device from "of-display" to "of-display.0" is confirmed to fix > the Debian Installer at the very least. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328 > Link: https://bugs.debian.org/1033058 > Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique") > Cc: stable@vger.kernel.org > Signed-off-by: Cyril Brulebois Reviewed-by: Michal Suchánek Thanks Michal > --- > drivers/video/fbdev/offb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c > index b97d251d894b..6264c7184457 100644 > --- a/drivers/video/fbdev/offb.c > +++ b/drivers/video/fbdev/offb.c > @@ -698,7 +698,7 @@ MODULE_DEVICE_TABLE(of, offb_of_match_display); > > static struct platform_driver offb_driver_display = { > .driver = { > - .name = "of-display", > + .name = "of-display.0", > .of_match_table = offb_of_match_display, > }, > .probe = offb_probe_display, > -- > 2.30.2 >