From: Peter Zijlstra <peterz@infradead.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Petr Pavlu <petr.pavlu@suse.com>,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com,
samitolvanen@google.com, x86@kernel.org,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] x86/kprobes: Prohibit probing on compiler generated CFI checking code
Date: Tue, 11 Jul 2023 09:04:45 +0200 [thread overview]
Message-ID: <20230711070445.GB3062772@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230711085837.fac80c964ea7667cb75bd6e5@kernel.org>
On Tue, Jul 11, 2023 at 08:58:37AM +0900, Masami Hiramatsu wrote:
> Oh, is FineIBT different from kCFI? I thought those are same. But anyway
> for kCFI=y && FineIBT=n case, I think this code still needed.
Yeah, FineIBT relies on kCFI and IBT (and selects CALL_PADDING) and
dynamically re-writes the kCFI infrastructure.
All the gory details are in arch/x86/kernel/alternative.c, search for
CONFIG_FINEIBT, I've tried to write a big comment, but please let me
know if something isn't clear and I'll write some actual words :-).
But basically kCFI is a pure software solution and does the check before
the indirect control transfer (it has to). While FineIBT relies on the
IBT hardware in order to do the check after.
As such, FineIBT can do the CFI check without memory loads, which is
good for performance. Another useful property of FineIBT is that it is a
speculation barrier.
next prev parent reply other threads:[~2023-07-11 7:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 12:14 [RFC PATCH 0/2] x86: kprobes: Fix CFI_CLANG related issues Masami Hiramatsu (Google)
2023-07-10 12:14 ` [RFC PATCH 1/2] kprobes: Prohibit probing on CFI preamble symbol Masami Hiramatsu (Google)
2023-07-10 15:37 ` Peter Zijlstra
2023-07-10 23:50 ` Masami Hiramatsu
2023-07-10 12:14 ` [RFC PATCH 2/2] x86/kprobes: Prohibit probing on compiler generated CFI checking code Masami Hiramatsu (Google)
2023-07-10 16:16 ` Peter Zijlstra
2023-07-10 16:21 ` Peter Zijlstra
2023-07-10 23:58 ` Masami Hiramatsu
2023-07-11 7:04 ` Peter Zijlstra [this message]
2023-07-11 7:15 ` Peter Zijlstra
2023-07-10 13:46 ` [RFC PATCH 0/2] x86: kprobes: Fix CFI_CLANG related issues Peter Zijlstra
2023-07-10 15:57 ` Nathan Chancellor
2023-07-11 1:33 ` Masami Hiramatsu
2023-07-11 18:37 ` Nathan Chancellor
2023-07-11 19:54 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711070445.GB3062772@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®