mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Hans de Goede <hdegoede@redhat.com>,
	Mark Gross <markgross@kernel.org>,
	<platform-driver-x86@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: Tobias Schaffner <tobias.schaffner@siemens.com>,
	Gerd Haeussler <gerd.haeussler.ext@siemens.com>,
	Henning Schild <henning.schild@siemens.com>
Subject: [PATCH 2/2] platform/x86: simatic-ipc: add auto-loading of hwmon modules
Date: Tue, 11 Jul 2023 14:08:42 +0200	[thread overview]
Message-ID: <20230711120842.30044-3-henning.schild@siemens.com> (raw)
In-Reply-To: <20230711120842.30044-1-henning.schild@siemens.com>

In order to know which hwmon modules to load one would have to usually
first probe from user-land i.e. with sensors-detect and create a config
for each machine. But here we know exactly what machines we are dealing
with, so we can request those howmon modules without user-mode detection
and config files.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 drivers/platform/x86/simatic-ipc.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/platform/x86/simatic-ipc.c b/drivers/platform/x86/simatic-ipc.c
index 71487216d33f..403dc231bef7 100644
--- a/drivers/platform/x86/simatic-ipc.c
+++ b/drivers/platform/x86/simatic-ipc.c
@@ -153,6 +153,21 @@ static int register_platform_devices(u32 station_id)
 	return 0;
 }
 
+static void request_additional_modules(u32 station_id)
+{
+	switch (station_id) {
+	case SIMATIC_IPC_IPC227G:
+	case SIMATIC_IPC_IPC277G:
+	case SIMATIC_IPC_IPCBX_39A:
+	case SIMATIC_IPC_IPCPX_39A:
+		request_module("nct6775");
+		break;
+	default:
+		request_module("emc1403");
+		break;
+	}
+}
+
 static int __init simatic_ipc_init_module(void)
 {
 	const struct dmi_system_id *match;
@@ -170,6 +185,8 @@ static int __init simatic_ipc_init_module(void)
 		return 0;
 	}
 
+	request_additional_modules(station_id);
+
 	return register_platform_devices(station_id);
 }
 
-- 
2.41.0


  parent reply	other threads:[~2023-07-11 12:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-11 12:08 [PATCH 0/2] platform/x86: simatic-ipc: add another model and hwmon module loading Henning Schild
2023-07-11 12:08 ` [PATCH 1/2] platform/x86: simatic-ipc: add another model Henning Schild
2023-07-11 12:08 ` Henning Schild [this message]
2023-07-12  7:21   ` [PATCH 2/2] platform/x86: simatic-ipc: add auto-loading of hwmon modules Henning Schild
2023-07-12 18:04     ` Hans de Goede
2023-07-11 12:10 ` [PATCH 0/2] platform/x86: simatic-ipc: add another model and hwmon module loading Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230711120842.30044-3-henning.schild@siemens.com \
    --to=henning.schild@siemens.com \
    --cc=gerd.haeussler.ext@siemens.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=tobias.schaffner@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®