From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26A72EB64DD for ; Tue, 11 Jul 2023 14:00:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233210AbjGKOAx (ORCPT ); Tue, 11 Jul 2023 10:00:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229714AbjGKOAp (ORCPT ); Tue, 11 Jul 2023 10:00:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2C9CE69 for ; Tue, 11 Jul 2023 07:00:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 69110614F9 for ; Tue, 11 Jul 2023 14:00:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78241C433C8; Tue, 11 Jul 2023 14:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689084040; bh=hwuogJ3ObcfPVVmSWTKMTekt8luIJ5KDC/wJPa8q7cc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MVKpNUtrvulQtO37zr4Pu9uuJI3y/k4cn24YAeUF/aUsrlj1axOER/BibykldFdlw qGZEuLPhpNvX/W4R6+WUrZMjHWnYQEDwekAmGQ+oV0s6hnvTRdqtxU/oRQuBXwDWcv a3oVQYK4kjNPBNuakiBaIqU12wikFYSL4sX2lfpg= Date: Tue, 11 Jul 2023 16:00:37 +0200 From: Greg KH To: Abhijit Gangurde Cc: linux-kernel@vger.kernel.org, Nipun.Gupta@amd.com, nikhil.agarwal@amd.com, puneet.gupta@amd.com, git@amd.com, michal.simek@amd.com, Pieter Jansen van Vuuren Subject: Re: [PATCH 3/4] cdx: create sysfs resource files Message-ID: <2023071148-grievance-gulf-0841@gregkh> References: <20230711121027.936487-1-abhijit.gangurde@amd.com> <20230711121027.936487-4-abhijit.gangurde@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230711121027.936487-4-abhijit.gangurde@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 11, 2023 at 05:40:26PM +0530, Abhijit Gangurde wrote: > Resource files provides the basic MMIO regions info to the > user-space. Also, resources devices can be used to mmap the > MMIO regions in the user-space. > > Co-developed-by: Puneet Gupta > Signed-off-by: Puneet Gupta > Co-developed-by: Nipun Gupta > Signed-off-by: Nipun Gupta > Signed-off-by: Abhijit Gangurde > Reviewed-by: Pieter Jansen van Vuuren > Tested-by: Nikhil Agarwal > --- > Documentation/ABI/testing/sysfs-bus-cdx | 15 +++ > drivers/cdx/cdx.c | 139 +++++++++++++++++++++++- > include/linux/cdx/cdx_bus.h | 10 ++ > 3 files changed, 163 insertions(+), 1 deletion(-) > > diff --git a/Documentation/ABI/testing/sysfs-bus-cdx b/Documentation/ABI/testing/sysfs-bus-cdx > index d9e00058471d..6ca47b6442ce 100644 > --- a/Documentation/ABI/testing/sysfs-bus-cdx > +++ b/Documentation/ABI/testing/sysfs-bus-cdx > @@ -76,3 +76,18 @@ Description: > For example:: > > # echo 1 > /sys/bus/cdx/devices/.../remove > + > +What: /sys/bus/cdx/devices/.../resource > +Date: July 2023 > +Contact: puneet.gupta@amd.com > +Description: > + The resource file contains host addresses of CDX device > + resources. Each line of the resource file describes a region > + with start, end, and flag fields. If you documented what this file looked like here, it would be obvious that this is not an acceptable sysfs file in any sense of the word. Please do so, and then fix the patch to not do that at all. thanks, greg k-h