mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Yangtao Li <frank.li@vivo.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 06/27] thermal/drivers/mediatek/lvts_thermal: Convert to platform remove callback returning void
Date: Wed, 12 Jul 2023 12:14:45 +0200	[thread overview]
Message-ID: <20230712101445.bci4qkcf33wkr66d@pengutronix.de> (raw)
In-Reply-To: <20230712081258.29254-6-frank.li@vivo.com>

[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]

On Wed, Jul 12, 2023 at 04:12:37PM +0800, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

While I like like you picking up the quest of converting drivers, I'd
like to have some coordination in place to not let us do duplicate work.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-07-12 10:15 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-12  8:12 [PATCH 01/27] thermal/drivers/amlogic: " Yangtao Li
2023-07-12  8:12 ` [PATCH 02/27] thermal/drivers/armada: " Yangtao Li
2023-07-12  8:46   ` Miquel Raynal
2023-07-12 12:44   ` Uwe Kleine-König
2023-07-12  8:12 ` [PATCH 03/27] thermal/drivers/broadcom: " Yangtao Li
2023-07-12 10:06   ` Uwe Kleine-König
2023-07-12 15:38   ` Florian Fainelli
2023-07-12  8:12 ` [PATCH 04/27] drivers/thermal/rcar_gen3_thermal: " Yangtao Li
2023-07-12 10:07   ` Uwe Kleine-König
2023-07-12 11:44   ` Geert Uytterhoeven
2023-07-12 13:22   ` Niklas Söderlund
2023-07-12  8:12 ` [PATCH 05/27] thermal/drivers/imx8mm_thermal: " Yangtao Li
2023-07-12  8:12 ` [PATCH 06/27] thermal/drivers/mediatek/lvts_thermal: " Yangtao Li
2023-07-12 10:14   ` Uwe Kleine-König [this message]
2023-07-12  8:12 ` [PATCH 07/27] thermal/drivers/qcom: " Yangtao Li
2023-07-12  8:12 ` [PATCH 08/27] thermal/drivers/hisi: " Yangtao Li
2023-07-12  8:12 ` [PATCH 09/27] thermal/drivers/spear: " Yangtao Li
2023-07-12  8:12 ` [PATCH 10/27] thermal/drivers/rockchip: " Yangtao Li
2023-07-12  8:12 ` [PATCH 11/27] thermal/drivers/uniphier: " Yangtao Li
2023-07-12  8:12 ` [PATCH 12/27] thermal/drivers/dove: " Yangtao Li
2023-07-12  8:12 ` [PATCH 13/27] thermal/drivers/k3_j72xx_bandgap: " Yangtao Li
2023-07-12  8:12 ` [PATCH 14/27] thermal/drivers/tegra-bpmp: " Yangtao Li
2023-07-12  8:12 ` [PATCH 15/27] thermal/drivers/imx: " Yangtao Li
2023-07-12  8:12 ` [PATCH 16/27] thermal/drivers/da9062: " Yangtao Li
2023-07-12  8:12 ` [PATCH 17/27] thermal/drivers/broadcom: " Yangtao Li
2023-07-12  8:12 ` [PATCH 18/27] thermal/drivers/rzg2l: " Yangtao Li
2023-07-12  8:12 ` [PATCH 19/27] drivers/thermal/k3: " Yangtao Li
2023-07-12  8:12 ` [PATCH 20/27] thermal/drivers/sprd: " Yangtao Li
2023-07-12  8:12 ` [PATCH 21/27] thermal/drivers/rcar_thermal: " Yangtao Li
2023-07-12 11:43   ` Geert Uytterhoeven
2023-07-12 12:49   ` Uwe Kleine-König
2023-07-12 13:23   ` Niklas Söderlund
2023-07-12  8:12 ` [PATCH 22/27] thermal/ti-soc-thermal: " Yangtao Li
2023-07-12  8:12 ` [PATCH 23/27] thermal/drivers/stm: " Yangtao Li
2023-07-12  8:12 ` [PATCH 24/27] thermal/drivers/tegra-soctherm: " Yangtao Li
2023-07-12  8:12 ` [PATCH 25/27] thermal/drivers/exynos: " Yangtao Li
2023-07-12  8:12 ` [PATCH 26/27] thermal/drivers/kirkwood: " Yangtao Li
2023-07-12  8:12 ` [PATCH 27/27] thermal: intel: int340x: " Yangtao Li
2023-07-14 19:01   ` Rafael J. Wysocki
2023-07-12 10:05 ` [PATCH 01/27] thermal/drivers/amlogic: " Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230712101445.bci4qkcf33wkr66d@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=amitk@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=frank.li@vivo.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®