From: Kees Cook <keescook@chromium.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Azeem Shaikh <azeemshaikh38@gmail.com>,
linux-hardening@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH] hwmon: Remove strlcpy occurences
Date: Wed, 12 Jul 2023 11:04:05 -0700 [thread overview]
Message-ID: <202307121100.A6E650B@keescook> (raw)
In-Reply-To: <3034082b-4ec8-2a8d-35a2-2551e9feef34@roeck-us.net>
On Wed, Jul 12, 2023 at 08:16:39AM -0700, Guenter Roeck wrote:
> On 7/12/23 07:44, Azeem Shaikh wrote:
> > [...]
> > + len = strlen(result);
> > return simple_read_from_buffer(buf, count, ppos, tbuf, len);
>
> This still copies tbuf, meaning all those constant strings won't actually
> be reported.
Ah dang, thanks for catching that. Yeah, "tbuf" should be replaced by
"result" in the simple_read_from_buffer().
--
Kees Cook
next prev parent reply other threads:[~2023-07-12 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 14:44 Azeem Shaikh
2023-07-12 15:16 ` Guenter Roeck
2023-07-12 18:04 ` Kees Cook [this message]
2023-07-12 19:25 ` Azeem Shaikh
2023-07-12 15:39 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202307121100.A6E650B@keescook \
--to=keescook@chromium.org \
--cc=azeemshaikh38@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome