From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CB8EEB64DD for ; Thu, 13 Jul 2023 07:59:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232947AbjGMH7X (ORCPT ); Thu, 13 Jul 2023 03:59:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233523AbjGMH6l (ORCPT ); Thu, 13 Jul 2023 03:58:41 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::226]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8463826B2; Thu, 13 Jul 2023 00:58:38 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 22C3FC0012; Thu, 13 Jul 2023 07:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1689235116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uAX8nljdTOdMazFudy7wuOfDuiEUUT5Bfk0pliYEkac=; b=nMwlXSalPIIAWtUgJTfi/Yre/CCnLsO9qIeQRH2X9XbMFMEBtdhvbHJUuUL1PS6VUcCIm/ /Ji983bKWzgTjpJ2p57MpGVBlDAtlHdanszczWbP8UtzHDIOL4PfjDiV+EHeWa9oPN5JxM Fd7CbTV43vnBCEv9dFd8J5xBqS/OucVPmesGMJVLtodx+XCCBvF2o7xlO5Rdo4kk9EaqHz AplBDIDxSojMGnkRrsTMTwyvlKpNBizoLeh3R98lUluUimUk67PG/RF31jf+1q440JI4GP Y0+GaVH+Olv8jQZL7vrrqo0sTqS+crFhOoRNDMMOwSBbdwQ4Apl86UpaSzpvww== From: Miquel Raynal To: William Zhang , Broadcom Kernel List , Linux MTD List Cc: Miquel Raynal , f.fainelli@gmail.com, rafal@milecki.pl, kursad.oney@broadcom.com, joel.peshkin@broadcom.com, computersforpeace@gmail.com, anand.gore@broadcom.com, dregan@mail.com, kamal.dasu@broadcom.com, tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com, Florian Fainelli , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Vignesh Raghavendra , Richard Weinberger , Kamal Dasu Subject: Re: [PATCH v4 4/5] mtd: rawnand: brcmnand: Fix potential out-of-bounds access in oob write Date: Thu, 13 Jul 2023 09:58:34 +0200 Message-Id: <20230713075834.486478-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230706182909.79151-5-william.zhang@broadcom.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b'5d53244186c9ac58cb88d76a0958ca55b83a15cd' Content-Transfer-Encoding: 8bit X-GND-Sasl: miquel.raynal@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2023-07-06 at 18:29:08 UTC, William Zhang wrote: > When the oob buffer length is not in multiple of words, the oob write > function does out-of-bounds read on the oob source buffer at the last > iteration. Fix that by always checking length limit on the oob buffer > read and fill with 0xff when reaching the end of the buffer to the oob > registers. > > Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller") > Signed-off-by: William Zhang > Reviewed-by: Florian Fainelli > Cc: stable@vger.kernel.org Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel