mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Minjie Du <duminjie@vivo.com>
To: Jiri Slaby <jirislaby@kernel.org>,
	Nick Kossifidis <mickflemm@gmail.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Kalle Valo <kvalo@kernel.org>,
	linux-wireless@vger.kernel.org (open list:ATHEROS ATH5K WIRELESS
	DRIVER), linux-kernel@vger.kernel.org (open list)
Cc: opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v4] wifi: ath5k: remove parameter check in ath5k_debug_init_device()
Date: Thu, 13 Jul 2023 16:24:32 +0800	[thread overview]
Message-ID: <20230713082433.11485-1-duminjie@vivo.com> (raw)

The parameter 'phydir' error check is mistake.
debugfs_create_file() will return early if 'phydir' is an error pointer,
so the error check is removed.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
v1: use IS_ERR() to error check.
v2: use IS_ERR_OR_NULL() to error check.
v3: remove the error check.
v4: fix the patch format.
---
 drivers/net/wireless/ath/ath5k/debug.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c
index 4b41160e5..ec130510a 100644
--- a/drivers/net/wireless/ath/ath5k/debug.c
+++ b/drivers/net/wireless/ath/ath5k/debug.c
@@ -982,8 +982,6 @@ ath5k_debug_init_device(struct ath5k_hw *ah)
 	ah->debug.level = ath5k_debug;
 
 	phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir);
-	if (!phydir)
-		return;
 
 	debugfs_create_file("debug", 0600, phydir, ah, &fops_debug);
 	debugfs_create_file("registers", 0400, phydir, ah, &registers_fops);
-- 
2.39.0


             reply	other threads:[~2023-07-13  8:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13  8:24 Minjie Du [this message]
     [not found] ` <288c6005-7d0b-3eb0-514d-e2ac09ae6b00@web.de>
2023-07-14  5:41   ` Jiri Slaby
     [not found]     ` <43838a39-6c31-bf90-19e9-0cf21503bccd@web.de>
2023-07-14  6:01       ` [v4] " Jiri Slaby
2023-07-14  6:13 ` [PATCH v4] " Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230713082433.11485-1-duminjie@vivo.com \
    --to=duminjie@vivo.com \
    --cc=jirislaby@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=mickflemm@gmail.com \
    --cc=opensource.kernel@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®