From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1CADC0015E for ; Thu, 13 Jul 2023 13:53:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231240AbjGMNxt (ORCPT ); Thu, 13 Jul 2023 09:53:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231197AbjGMNxq (ORCPT ); Thu, 13 Jul 2023 09:53:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80D1C212B for ; Thu, 13 Jul 2023 06:53:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 047646103B for ; Thu, 13 Jul 2023 13:53:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2091C433C7; Thu, 13 Jul 2023 13:53:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689256422; bh=UeaSMYpNYYjbPUlQQ7PGsvIDiHGPFgkb5c0Jd/WB39Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dPkP6DcvbdeotpDpskeh3bHul8uTlUjuu6WxEN5aYWni34hp6OoM92ChMB4ArfWUS 0HdQh0Gg2l5IFftFgi0U1qoXWk9plvPvLWv/fDX/oxRjjLj1Z2wiAcd83ZhHyvu1Yz 9NRm+ndtxTOFwIgzupVzxn778tWYE3EPhrOP3dgo= Date: Thu, 13 Jul 2023 15:53:38 +0200 From: Greg Kroah-Hartman To: Wang Ming Cc: Akinobu Mita , David Hildenbrand , Andrew Morton , linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH v2] lib: Remove error checking for debugfs_create_dir() Message-ID: <2023071326-preachy-renewably-2ec8@gregkh> References: <20230713082455.2415-1-machel@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230713082455.2415-1-machel@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 13, 2023 at 04:24:43PM +0800, Wang Ming wrote: > It is expected that most callers should _ignore_ the errors return by > debugfs_create_dir() in err_inject_init(). > > Signed-off-by: Wang Ming > --- > lib/notifier-error-inject.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/lib/notifier-error-inject.c b/lib/notifier-error-inject.c > index 2b24ea6c9497..954c3412d22d 100644 > --- a/lib/notifier-error-inject.c > +++ b/lib/notifier-error-inject.c > @@ -83,9 +83,6 @@ static int __init err_inject_init(void) > notifier_err_inject_dir = > debugfs_create_dir("notifier-error-inject", NULL); > > - if (!notifier_err_inject_dir) > - return -ENOMEM; > - > return 0; > } > > -- > 2.25.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot