From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Cezary Rojewski" <cezary.rojewski@intel.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v3 03/15] ASoC: SOF: Remove unused Broxton PCI ID
Date: Fri, 14 Jul 2023 22:24:45 +0200 [thread overview]
Message-ID: <20230714202457.423866-4-amadeuszx.slawinski@linux.intel.com> (raw)
In-Reply-To: <20230714202457.423866-1-amadeuszx.slawinski@linux.intel.com>
Current code references 0x1a98 which is BXT-M (not -T as it is
commented) and it's an RVP, BXT-M B0 to be specific. From what we know
no BXT is available on market.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
---
sound/hda/intel-dsp-config.c | 7 -------
sound/soc/sof/intel/pci-apl.c | 2 --
2 files changed, 9 deletions(-)
diff --git a/sound/hda/intel-dsp-config.c b/sound/hda/intel-dsp-config.c
index 317bdf6dcbef..5cee995f7a42 100644
--- a/sound/hda/intel-dsp-config.c
+++ b/sound/hda/intel-dsp-config.c
@@ -53,13 +53,6 @@ static const struct config_entry config_table[] = {
.device = 0x119a,
},
#endif
-/* Broxton-T */
-#if IS_ENABLED(CONFIG_SND_SOC_SOF_APOLLOLAKE)
- {
- .flags = FLAG_SOF,
- .device = 0x1a98,
- },
-#endif
/*
* Apollolake (Broxton-P)
* the legacy HDAudio driver is used except on Up Squared (SOF) and
diff --git a/sound/soc/sof/intel/pci-apl.c b/sound/soc/sof/intel/pci-apl.c
index 69cad5a6bc72..bc3ad64baec5 100644
--- a/sound/soc/sof/intel/pci-apl.c
+++ b/sound/soc/sof/intel/pci-apl.c
@@ -87,8 +87,6 @@ static const struct sof_dev_desc glk_desc = {
static const struct pci_device_id sof_pci_ids[] = {
{ PCI_DEVICE(0x8086, 0x5a98), /* BXT-P (ApolloLake) */
.driver_data = (unsigned long)&bxt_desc},
- { PCI_DEVICE(0x8086, 0x1a98),/* BXT-T */
- .driver_data = (unsigned long)&bxt_desc},
{ PCI_DEVICE(0x8086, 0x3198), /* GeminiLake */
.driver_data = (unsigned long)&glk_desc},
{ 0, }
--
2.34.1
next prev parent reply other threads:[~2023-07-14 12:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 20:24 [PATCH v3 00/15] PCI: Define Intel PCI IDs and use them in drivers Amadeusz Sławiński
2023-07-14 12:36 ` Andy Shevchenko
2023-07-14 13:09 ` Mark Brown
2023-07-14 19:03 ` Cezary Rojewski
2023-07-14 20:24 ` [PATCH v3 01/15] PCI: Sort Intel PCI IDs by number Amadeusz Sławiński
2023-07-14 20:24 ` [PATCH v3 02/15] PCI: Add Intel Audio DSP devices to pci_ids.h Amadeusz Sławiński
2023-07-14 20:24 ` Amadeusz Sławiński [this message]
2023-07-14 12:35 ` [PATCH v3 03/15] ASoC: SOF: Remove unused Broxton PCI ID Andy Shevchenko
2023-07-14 12:44 ` Amadeusz Sławiński
2023-07-14 12:46 ` Andy Shevchenko
2023-07-14 20:24 ` [PATCH v3 04/15] ALSA: " Amadeusz Sławiński
2023-07-14 20:24 ` [PATCH v3 05/15] ALSA: hda: Add controller matching macros Amadeusz Sławiński
2023-07-14 20:24 ` [PATCH v3 06/15] ALSA: hda: Use global PCI match macro Amadeusz Sławiński
2023-07-14 20:24 ` [PATCH v3 07/15] ALSA: hda/i915: " Amadeusz Sławiński
2023-07-14 12:29 ` Ilpo Järvinen
2023-07-14 20:24 ` [PATCH v3 08/15] ASoC: Intel: Skylake: " Amadeusz Sławiński
2023-07-14 20:24 ` [PATCH v3 09/15] ALSA: intel-dsp-config: Convert to PCI device IDs defines Amadeusz Sławiński
2023-07-14 20:24 ` [PATCH v3 10/15] ALSA: hda: " Amadeusz Sławiński
2023-07-14 20:24 ` [PATCH v3 11/15] ASoC: Intel: avs: " Amadeusz Sławiński
2023-07-14 20:24 ` [PATCH v3 12/15] " Amadeusz Sławiński
2023-07-14 20:24 ` [PATCH v3 13/15] ASoC: Intel: Skylake: " Amadeusz Sławiński
2023-07-14 20:24 ` [PATCH v3 14/15] ASoC: SOF: Intel: " Amadeusz Sławiński
2023-07-14 20:24 ` [PATCH v3 15/15] ASoC: Intel: sst: " Amadeusz Sławiński
2023-07-14 12:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230714202457.423866-4-amadeuszx.slawinski@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®