From: Greg KH <gregkh@linuxfoundation.org>
To: liubin001@208suo.com
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Fwd: [PATCH] tty:Insert clk_put before return (clk) to release memory
Date: Fri, 14 Jul 2023 06:44:44 +0200 [thread overview]
Message-ID: <2023071424-folic-boss-18e3@gregkh> (raw)
In-Reply-To: <57adb092639743f2619c4765379b3ec7@208suo.com>
On Fri, Jul 14, 2023 at 12:30:14PM +0800, liubin001@208suo.com wrote:
>
> tty/serial:Insert clk_put before return (clk) to release memory
> Signed-off-by: Liu Bin <liubin001@08suo.com>
> ---
> drivers/tty/serial/bcm63xx_uart.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/bcm63xx_uart.c
> b/drivers/tty/serial/bcm63xx_uart.c
> index 55e82d0bf92d..7353b683952d 100644
> --- a/drivers/tty/serial/bcm63xx_uart.c
> +++ b/drivers/tty/serial/bcm63xx_uart.c
> @@ -851,6 +851,7 @@ static int bcm_uart_probe(struct platform_device *pdev)
> clk = of_clk_get(pdev->dev.of_node, 0);
>
> if (IS_ERR(clk))
> + clk_put(clk);
> return -ENODEV;
>
> port->iotype = UPIO_MEM;
This obviously has not even been tested :(
next prev parent reply other threads:[~2023-07-14 4:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_EF85BF6D0EE7D05E10D527FD335467508106@qq.com>
2023-07-14 4:30 ` liubin001
2023-07-14 4:44 ` Greg KH [this message]
2023-07-14 11:48 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023071424-folic-boss-18e3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=liubin001@208suo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®