From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Johan Jonker <jbx6244@gmail.com>, miquel.raynal@bootlin.com
Cc: richard@nod.at, vigneshr@ti.com, heiko@sntech.de,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, yifeng.zhao@rock-chips.com
Subject: Re: [PATCH v5 1/2] mtd: rawnand: rockchip: fix oobfree offset and description
Date: Sat, 15 Jul 2023 18:19:25 +0200 [thread overview]
Message-ID: <20230715161925.20644-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <d202f12d-188c-20e8-f2c2-9cc874ad4d22@gmail.com>
On Fri, 2023-07-14 at 15:21:01 UTC, Johan Jonker wrote:
> Rockchip boot blocks are written per 4 x 512 byte sectors per page.
> Each page with boot blocks must have a page address (PA) pointer in OOB
> to the next page.
>
> The currently advertised free OOB area starts at offset 6, like
> if 4 PA bytes were located right after the BBM. This is wrong as the
> PA bytes are located right before the ECC bytes.
>
> Fix the layout by allowing access to all bytes between the BBM and the
> PA bytes instead of reserving 4 bytes right after the BBM.
>
> This change breaks existing jffs2 users.
>
> Fixes: 058e0e847d54 ("mtd: rawnand: rockchip: NFC driver for RK3308, RK2928 and others")
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.
Miquel
next prev parent reply other threads:[~2023-07-15 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 15:19 [PATCH v5 0/2] Fixes for Rockchip NAND controller driver Johan Jonker
2023-07-14 15:21 ` [PATCH v5 1/2] mtd: rawnand: rockchip: fix oobfree offset and description Johan Jonker
2023-07-15 16:19 ` Miquel Raynal [this message]
2023-07-14 15:21 ` [PATCH v5 2/2] mtd: rawnand: rockchip: Align hwecc vs. raw page helper layouts Johan Jonker
2023-07-15 16:19 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230715161925.20644-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®