From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Robert Marko <robert.marko@sartura.hr>,
Luka Perkov <luka.perkov@sartura.hr>,
Michael Walle <michael@walle.cc>,
Randy Dunlap <rdunlap@infradead.org>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [PATCH v6 2/3] nvmem: core: Create all cells before adding the nvmem device
Date: Mon, 17 Jul 2023 09:51:46 +0200 [thread overview]
Message-ID: <20230717075147.43326-3-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20230717075147.43326-1-miquel.raynal@bootlin.com>
Let's pack all the cells creation in one place, so they are all created
before we add the nvmem device.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
drivers/nvmem/core.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 3f8c7718412b..48659106a1e2 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -998,12 +998,6 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
if (rval)
goto err_remove_cells;
- dev_dbg(&nvmem->dev, "Registering nvmem device %s\n", config->name);
-
- rval = device_add(&nvmem->dev);
- if (rval)
- goto err_remove_cells;
-
rval = nvmem_add_cells_from_fixed_layout(nvmem);
if (rval)
goto err_remove_cells;
@@ -1012,6 +1006,12 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
if (rval)
goto err_remove_cells;
+ dev_dbg(&nvmem->dev, "Registering nvmem device %s\n", config->name);
+
+ rval = device_add(&nvmem->dev);
+ if (rval)
+ goto err_remove_cells;
+
blocking_notifier_call_chain(&nvmem_notifier, NVMEM_ADD, nvmem);
return nvmem;
--
2.34.1
next prev parent reply other threads:[~2023-07-17 7:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 7:51 [PATCH v6 0/3] NVMEM cells in sysfs Miquel Raynal
2023-07-17 7:51 ` [PATCH v6 1/3] ABI: sysfs-nvmem-cells: Expose cells through sysfs Miquel Raynal
2023-07-23 19:39 ` John Thomson
2023-07-31 15:51 ` Miquel Raynal
2023-08-01 9:06 ` Srinivas Kandagatla
2023-08-01 16:50 ` Miquel Raynal
2023-07-17 7:51 ` Miquel Raynal [this message]
2023-07-17 7:51 ` [PATCH v6 3/3] nvmem: core: " Miquel Raynal
2023-07-17 12:24 ` Michael Walle
2023-07-17 16:41 ` Miquel Raynal
2023-07-17 14:32 ` Greg Kroah-Hartman
2023-07-17 16:33 ` Miquel Raynal
2023-07-17 16:59 ` Greg Kroah-Hartman
2023-07-31 15:33 ` Miquel Raynal
2023-08-01 9:56 ` Greg Kroah-Hartman
2023-08-01 16:54 ` Miquel Raynal
2023-07-18 10:26 ` Chen-Yu Tsai
2023-07-31 16:05 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230717075147.43326-3-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=michael@walle.cc \
--cc=rdunlap@infradead.org \
--cc=robert.marko@sartura.hr \
--cc=srinivas.kandagatla@linaro.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®