From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9058CEB64DC for ; Mon, 17 Jul 2023 09:53:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231232AbjGQJxo (ORCPT ); Mon, 17 Jul 2023 05:53:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231207AbjGQJxl (ORCPT ); Mon, 17 Jul 2023 05:53:41 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AAD310E6 for ; Mon, 17 Jul 2023 02:53:37 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 36H5oWhv024979; Mon, 17 Jul 2023 04:52:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=PODMain02222019; bh=6lLcMdE7NiLfYmz f5rN6MtAOjyshk3EubvQ+zTuLmNs=; b=FYkhSLj2mADwEQ1rtSlFG1Tqo170qOz +D04Rc4fTCOhLdGWqKDU84c/zKLSY9gk+H8wHuCl+DhbYb/OrP3SZkxlE8QT/212 ffZNsLuLkJrKm0qhTk4YIRVYEkkcBz4UA0c4hzex03jOXXquQ5rz2maZK02zZGtz X7Ldx764gj4SkZ1OtuPc0omYEZIbEDrvhAeRRaKhdrHtuqm0KSj7DoDKNeo8Xvsi O8BDnKUZj/CI2MW4019GxNWySORM4N5uoqiP3tqeTVzcOA6tDwA0wOr/6QFOtZRT 6RBm+nS5zK6Dpj09/e5oF3GVeCs2Op/h/CvK+6cnzClrJbrhAvfTRrg== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3rus6gsw03-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jul 2023 04:52:55 -0500 (CDT) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Mon, 17 Jul 2023 10:52:54 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.30 via Frontend Transport; Mon, 17 Jul 2023 10:52:54 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 2E84A475; Mon, 17 Jul 2023 09:52:54 +0000 (UTC) Date: Mon, 17 Jul 2023 09:52:54 +0000 From: Charles Keepax To: Frank Li CC: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Vladimir Oltean , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Krzysztof =?utf-8?Q?Ha=C5=82asa?= , Wolfram Sang , Heikki Krogerus , "open list:WOLFSON MICROELECTRONICS DRIVERS" , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list , , Subject: Re: [PATCH 1/1] ASoC: codec: wm8960: add additional probe check for codec identification Message-ID: <20230717095254.GA103419@ediswmail.ad.cirrus.com> References: <20230713222513.1636591-1-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230713222513.1636591-1-Frank.Li@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-ORIG-GUID: dVkVXtwqOw-GMPTnfGpvGuJ4O8g7sUG6 X-Proofpoint-GUID: dVkVXtwqOw-GMPTnfGpvGuJ4O8g7sUG6 X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 13, 2023 at 06:25:12PM -0400, Frank Li wrote: > The wm8960 codec is not readable, resulting in a NACK for address 0x3d (8-bit). > This can partially indicate it. For example: wm8962 codec use the same address > but is readable. This additional probe check will help prevent loading the wm8960 > module incorrectly on wm8962 hardware. > > Signed-off-by: Frank Li > --- Seems reasonable to me: Acked-by: Charles Keepax Thanks, Charles