From: Peter Zijlstra <peterz@infradead.org>
To: Chin Yik Ming <yikming2222@gmail.com>
Cc: mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: Fixed typo in comment
Date: Mon, 17 Jul 2023 12:55:04 +0200 [thread overview]
Message-ID: <20230717105504.GG4253@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230717064952.2804-1-yikming2222@gmail.com>
On Mon, Jul 17, 2023 at 02:49:52PM +0800, Chin Yik Ming wrote:
> task_struct's state member is prefixed by "__"
This isn't a typo, the member got renamed long after these comments were
written.
Also, nobody should be accessing task->__state, so it being spelled
wrong in a comment doesn't seem like a problem to me.
next prev parent reply other threads:[~2023-07-17 10:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 6:49 Chin Yik Ming
2023-07-17 8:16 ` Daniel Bristot de Oliveira
2023-07-17 10:55 ` Peter Zijlstra [this message]
2023-07-17 12:56 ` [tip: sched/core] sched/headers: Rename task_struct::state to task_strate::__state in the comments too tip-bot2 for Chin Yik Ming
2023-07-19 7:47 ` [tip: sched/core] sched/headers: Rename task_struct::state to task_struct::__state " tip-bot2 for Chin Yik Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230717105504.GG4253@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yikming2222@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome