mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
	rostedt@goodmis.org, Alan Huang <mmpgouride@gmail.com>,
	"Paul E . McKenney" <paulmck@kernel.org>
Subject: [PATCH rcu 6/6] rcu: Use WRITE_ONCE() for assignments to ->next for rculist_nulls
Date: Mon, 17 Jul 2023 11:03:17 -0700	[thread overview]
Message-ID: <20230717180317.1097590-6-paulmck@kernel.org> (raw)
In-Reply-To: <6127192c-da9b-4599-9738-6e8f92e6c75c@paulmck-laptop>

From: Alan Huang <mmpgouride@gmail.com>

When the objects managed by rculist_nulls are allocated with
SLAB_TYPESAFE_BY_RCU, old readers may still hold references to an object
even though it is just now being added, which means the modification of
->next is visible to readers.  This patch therefore uses WRITE_ONCE()
for assignments to ->next.

Signed-off-by: Alan Huang <mmpgouride@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
 include/linux/rculist_nulls.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/rculist_nulls.h b/include/linux/rculist_nulls.h
index ba4c00dd8005..89186c499dd4 100644
--- a/include/linux/rculist_nulls.h
+++ b/include/linux/rculist_nulls.h
@@ -101,7 +101,7 @@ static inline void hlist_nulls_add_head_rcu(struct hlist_nulls_node *n,
 {
 	struct hlist_nulls_node *first = h->first;
 
-	n->next = first;
+	WRITE_ONCE(n->next, first);
 	WRITE_ONCE(n->pprev, &h->first);
 	rcu_assign_pointer(hlist_nulls_first_rcu(h), n);
 	if (!is_a_nulls(first))
@@ -137,7 +137,7 @@ static inline void hlist_nulls_add_tail_rcu(struct hlist_nulls_node *n,
 		last = i;
 
 	if (last) {
-		n->next = last->next;
+		WRITE_ONCE(n->next, last->next);
 		n->pprev = &last->next;
 		rcu_assign_pointer(hlist_nulls_next_rcu(last), n);
 	} else {
-- 
2.40.1


  parent reply	other threads:[~2023-07-17 18:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 18:03 [PATCH rcu 0/6] Miscellaneous fixes for v6.6 Paul E. McKenney
2023-07-17 18:03 ` [PATCH rcu 1/6] rcu: Update synchronize_rcu_mult() comment for call_rcu_hurry() Paul E. McKenney
2023-07-18 12:59   ` Joel Fernandes
2023-07-17 18:03 ` [PATCH rcu 2/6] rcu: Clarify rcu_is_watching() kernel-doc comment Paul E. McKenney
2023-07-18 12:52   ` Joel Fernandes
2023-07-18 18:12     ` Paul E. McKenney
2023-07-19  1:56       ` Joel Fernandes
2023-07-19 20:38         ` Paul E. McKenney
2023-07-17 18:03 ` [PATCH rcu 3/6] srcu,notifier: Remove #ifdefs in favor of SRCU Tiny srcu_usage Paul E. McKenney
2023-07-17 18:09   ` Linus Torvalds
2023-07-17 18:16     ` Paul E. McKenney
2023-07-17 18:03 ` [PATCH rcu 4/6] rcu: Mark __rcu_irq_enter_check_tick() ->rcu_urgent_qs load Paul E. McKenney
2023-07-18 12:58   ` Joel Fernandes
2023-07-17 18:03 ` [PATCH rcu 5/6] rcu: Make the rcu_nocb_poll boot parameter usable via boot config Paul E. McKenney
2023-07-18 13:46   ` Joel Fernandes
2023-07-17 18:03 ` Paul E. McKenney [this message]
2023-07-18 13:49   ` [PATCH rcu 6/6] rcu: Use WRITE_ONCE() for assignments to ->next for rculist_nulls Joel Fernandes
2023-07-18 14:48     ` Alan Huang
2023-07-18 18:32       ` Paul E. McKenney
2023-07-19  1:48         ` Joel Fernandes
2023-07-19 18:20           ` Paul E. McKenney
2023-07-19 19:17             ` Alan Huang
2023-07-19 20:02               ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230717180317.1097590-6-paulmck@kernel.org \
    --to=paulmck@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmpgouride@gmail.com \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®