From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF1DDEB64DD for ; Tue, 18 Jul 2023 17:17:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229904AbjGRRRn (ORCPT ); Tue, 18 Jul 2023 13:17:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233422AbjGRRRh (ORCPT ); Tue, 18 Jul 2023 13:17:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C0CC1705 for ; Tue, 18 Jul 2023 10:17:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A16DD6167F for ; Tue, 18 Jul 2023 17:17:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE648C433C7; Tue, 18 Jul 2023 17:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1689700656; bh=+hnVIU5zZw20GkGYfgr8/6QlYnCVkhQQSbU4SSZMDx0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ExelwVvvbfz9f2iFh1sPcovf3jrbZCGCYNo3HuoHrWS22IhKYMGmb+qlDfN/XP56q VhumL5/yHIgtvTHSG0VffwaoPOXxYz8gjmQB3yn3n8SmEqhI3lv4Xkk3x0NCaeytTY xeLoXXDMUnbmlgNvEnGs5u9j05iQCt0Fns1DoEwA= Date: Tue, 18 Jul 2023 10:17:35 -0700 From: Andrew Morton To: sunran001@208suo.com Cc: dennis@kernel.org, tj@kernel.org, cl@linux.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/percpu.c: change GFP_KERNEL to GFP_ATOMIC Message-Id: <20230718101735.aa31791899e2f9e19e8e0a75@linux-foundation.org> In-Reply-To: <7aa3a1cee63518cb13906d11ea130c9c@208suo.com> References: <20230718063328.16140-1-xujianghui@cdjrlc.com> <7aa3a1cee63518cb13906d11ea130c9c@208suo.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Jul 2023 14:35:11 +0800 sunran001@208suo.com wrote: > ERROR: function pcpu_balance_populated called on line 2238 inside lock > on line 2234 but uses GFP_KERNEL > > Generated by: scripts/coccinelle/locks/call_kern.cocci > > ... > > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -2033,7 +2033,7 @@ static void pcpu_balance_free(bool empty_only) > static void pcpu_balance_populated(void) > { > /* gfp flags passed to underlying allocators */ > - const gfp_t gfp = GFP_KERNEL | __GFP_NORETRY | __GFP_NOWARN; > + const gfp_t gfp = GFP_ATOMIC | __GFP_NORETRY | __GFP_NOWARN; > struct pcpu_chunk *chunk; > int slot, nr_to_pop, ret; I don't believe this warning is correct. spin_unlock_irq(&pcpu_lock); ret = pcpu_populate_chunk(chunk, rs, rs + nr, gfp); cond_resched(); spin_lock_irq(&pcpu_lock);