From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 140DDC001DC for ; Tue, 18 Jul 2023 18:36:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230248AbjGRSgZ (ORCPT ); Tue, 18 Jul 2023 14:36:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229621AbjGRSgX (ORCPT ); Tue, 18 Jul 2023 14:36:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1413DA; Tue, 18 Jul 2023 11:36:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3354B616A9; Tue, 18 Jul 2023 18:36:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE9F2C433C8; Tue, 18 Jul 2023 18:36:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1689705381; bh=JgrHe5DZ5UnZ31Le+DdrjV7UqhJAEhx+BMwzO0I0pyk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rSwv4V3DUswnOOwtuqviHoHg8mtQl8Mycp8naGrr017s7gsEUs+LUFgW78b59OlD6 RJ07+aYugwPVV2ffN02N+TbXLoW/RPNxLL/RW1q/hReBJmWPBWvyF6ARM4VWnVkHi/ WwOrnVSIGZK5bXjK7yuuDSaj1cyDMcQJVsSO4MIU= Date: Tue, 18 Jul 2023 11:36:20 -0700 From: Andrew Morton To: Jason Gunthorpe Cc: Alistair Popple , ajd@linux.ibm.com, catalin.marinas@arm.com, fbarrat@linux.ibm.com, iommu@lists.linux.dev, jhubbard@nvidia.com, kevin.tian@intel.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, nicolinc@nvidia.com, npiggin@gmail.com, robin.murphy@arm.com, seanjc@google.com, will@kernel.org, x86@kernel.org, zhi.wang.linux@gmail.com Subject: Re: [PATCH 1/4] mm_notifiers: Rename invalidate_range notifier Message-Id: <20230718113620.fb29217344238307c3be76d7@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Jul 2023 14:57:12 -0300 Jason Gunthorpe wrote: > On Tue, Jul 18, 2023 at 05:56:15PM +1000, Alistair Popple wrote: > > diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h > > index b466172..48c81b9 100644 > > --- a/include/asm-generic/tlb.h > > +++ b/include/asm-generic/tlb.h > > @@ -456,7 +456,7 @@ static inline void tlb_flush_mmu_tlbonly(struct mmu_gather *tlb) > > return; > > > > tlb_flush(tlb); > > - mmu_notifier_invalidate_range(tlb->mm, tlb->start, tlb->end); > > + mmu_notifier_invalidate_secondary_tlbs(tlb->mm, tlb->start, tlb->end); > > __tlb_reset_range(tlb); > > Does this compile? I don't see > "mmu_notifier_invalidate_secondary_tlbs" ? Seems this call gets deleted later in the series. > But I think the approach in this series looks fine, it is so much > cleaner after we remove all the cruft in patch 4, just look at the > diffstat.. I'll push this into -next if it compiles OK for me, but yes, a redo is desirable please.