mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexandru Ardelean <alex@shruggie.ro>
To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: bogdan.togorean@analog.com, nuno.sa@analog.com, daniel@ffwll.ch,
	airlied@gmail.com, jonas@kwiboo.se,
	Laurent.pinchart@ideasonboard.com, rfoss@kernel.org,
	neil.armstrong@linaro.org, andrzej.hajda@intel.com,
	festevam@gmail.com, Alexandru Ardelean <alex@shruggie.ro>
Subject: [PATCH v4] drm: adv7511: Fix low refresh rate register for ADV7533/5
Date: Wed, 19 Jul 2023 09:01:43 +0300	[thread overview]
Message-ID: <20230719060143.63649-1-alex@shruggie.ro> (raw)
In-Reply-To: <20190716131005.761-1-bogdan.togorean@analog.com>

From: Bogdan Togorean <bogdan.togorean@analog.com>

For ADV7533 and ADV7535 low refresh rate is selected using
bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
Reviewed-by: Robert Foss <rfoss@kernel.org>
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
---
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index ddceafa7b637..8d6c93296503 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
 	else
 		low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
 
-	regmap_update_bits(adv7511->regmap, 0xfb,
-		0x6, low_refresh_rate << 1);
+	if (adv7511->type == ADV7511)
+		regmap_update_bits(adv7511->regmap, 0xfb,
+				   0x6, low_refresh_rate << 1);
+	else
+		regmap_update_bits(adv7511->regmap, 0x4a,
+				   0xc, low_refresh_rate << 2);
+
 	regmap_update_bits(adv7511->regmap, 0x17,
 		0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
 
-- 
2.41.0


  parent reply	other threads:[~2023-07-19  6:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-16 13:10 [PATCH] " Bogdan Togorean
2023-07-18  6:28 ` [PATCH V2] " Alexandru Ardelean
2023-07-18  7:03   ` Nuno Sá
2023-07-18  8:35     ` Alexandru Ardelean
2023-07-18  8:42 ` [PATCH v3] " Alexandru Ardelean
2023-07-18  8:49   ` Robert Foss
2023-07-18 11:45     ` Alexandru Ardelean
2023-07-18 12:21       ` Nuno Sá
2023-07-19  6:01 ` Alexandru Ardelean [this message]
2023-07-20  7:30   ` [PATCH v4] " Alexandru Ardelean
2023-07-20  7:44   ` Frieder Schrempf
2023-07-21 11:48   ` Robert Foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230719060143.63649-1-alex@shruggie.ro \
    --to=alex@shruggie.ro \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=bogdan.togorean@analog.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=nuno.sa@analog.com \
    --cc=rfoss@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®