From: "Petr Tesařík" <petr@tesarici.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Petr Tesarik <petrtesarik@huaweicloud.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Juergen Gross <jgross@suse.com>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Petr Tesarik <petr.tesarik.ext@huawei.com>,
Jonathan Corbet <corbet@lwn.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>, James Seo <james@equiv.tech>,
James Clark <james.clark@arm.com>,
Kees Cook <keescook@chromium.org>,
"moderated list:XEN HYPERVISOR ARM"
<xen-devel@lists.xenproject.org>,
"moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:MIPS" <linux-mips@vger.kernel.org>,
"open list:XEN SWIOTLB SUBSYSTEM" <iommu@lists.linux.dev>,
Roberto Sassu <roberto.sassu@huaweicloud.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH v4 0/8] Allow dynamic allocation of software IO TLB bounce buffers
Date: Thu, 20 Jul 2023 10:13:20 +0200 [thread overview]
Message-ID: <20230720101320.72bbd2fc@meshulam.tesarici.cz> (raw)
In-Reply-To: <20230720065216.GB4395@lst.de>
On Thu, 20 Jul 2023 08:52:16 +0200
Christoph Hellwig <hch@lst.de> wrote:
> Just to add a highlevel comment here after I feel like I need a little
> more time to review the guts.
>
> I'm still pretty concerned about the extra list that needs to be
> consulted in is_swiotlb_buffer, but I can't really think of
> anything better. Maybe an xarray has better cache characteristics,
> but that one requires even more allocations in the low-level dma map
> path.
>
> One thing I'd like to see for the next version is to make the
> new growing code a config option at least for now. It is a pretty
> big change of the existing swiotlb behavior, and I want people to opt
> into it conciously. Maybe we can drop the option again after a few
> years once everything has settled.
Fine with me. I removed it after all my testing showed no performance
impact as long as the size of the initial SWIOTLB is kept at the
default value (and sufficient for the workload), but it's OK for me if
dynamic SWIOTLB allocations are off by default.
OTOH I'd like to make it a boot-time option rather than build-time
option. Would that be OK for you?
Petr T
next prev parent reply other threads:[~2023-07-20 8:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 15:23 Petr Tesarik
2023-07-13 15:23 ` [PATCH v4 1/8] swiotlb: make io_tlb_default_mem local to swiotlb.c Petr Tesarik
2023-07-17 6:06 ` Philippe Mathieu-Daudé
2023-07-17 10:17 ` Petr Tesařík
2023-07-20 6:37 ` Christoph Hellwig
2023-07-20 7:54 ` Petr Tesařík
2023-07-13 15:23 ` [PATCH v4 2/8] swiotlb: add documentation and rename swiotlb_do_find_slots() Petr Tesarik
2023-07-20 6:38 ` Christoph Hellwig
2023-07-20 7:56 ` Petr Tesařík
2023-07-20 8:01 ` Christoph Hellwig
2023-07-20 8:14 ` Petr Tesařík
2023-07-13 15:23 ` [PATCH v4 3/8] swiotlb: separate memory pool data from other allocator data Petr Tesarik
2023-07-13 17:53 ` Petr Tesařík
2023-07-13 15:23 ` [PATCH v4 4/8] swiotlb: add a flag whether a SWIOTLB is allowed to grow Petr Tesarik
2023-07-13 15:23 ` [PATCH v4 5/8] swiotlb: if swiotlb is full, fall back to a transient memory pool Petr Tesarik
2023-07-13 15:23 ` [PATCH v4 6/8] swiotlb: determine potential physical address limit Petr Tesarik
2023-07-13 15:23 ` [PATCH v4 7/8] swiotlb: allocate a new memory pool when existing pools are full Petr Tesarik
2023-07-13 15:23 ` [PATCH v4 8/8] swiotlb: search the software IO TLB only if a device makes use of it Petr Tesarik
2023-07-20 6:47 ` Christoph Hellwig
2023-07-20 8:02 ` Petr Tesařík
2023-07-20 8:22 ` Christoph Hellwig
2023-07-20 6:52 ` [PATCH v4 0/8] Allow dynamic allocation of software IO TLB bounce buffers Christoph Hellwig
2023-07-20 8:13 ` Petr Tesařík [this message]
2023-07-20 8:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720101320.72bbd2fc@meshulam.tesarici.cz \
--to=petr@tesarici.cz \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux.dev \
--cc=james.clark@arm.com \
--cc=james@equiv.tech \
--cc=jgross@suse.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=mingo@redhat.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=petr.tesarik.ext@huawei.com \
--cc=petrtesarik@huaweicloud.com \
--cc=rafael@kernel.org \
--cc=roberto.sassu@huaweicloud.com \
--cc=robin.murphy@arm.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=wangkefeng.wang@huawei.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome