From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5C33C001DC for ; Fri, 21 Jul 2023 12:09:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231405AbjGUMJe (ORCPT ); Fri, 21 Jul 2023 08:09:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230427AbjGUMJc (ORCPT ); Fri, 21 Jul 2023 08:09:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30E90172D for ; Fri, 21 Jul 2023 05:09:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AEC6161961 for ; Fri, 21 Jul 2023 12:09:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A42B1C433C8; Fri, 21 Jul 2023 12:09:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689941371; bh=WOYMgeLTYhtudrkqkThYSmblybXLug2suDbKhngipgU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Eo/Pvgfby/LygRdRVZBEg8k07M9qOd9WlBap7SM0rEe43UaqybHHlsZYNhuomEf71 AK82+RIMVH2F2yNOLepKqy0ITncSghK4pDF33VxysekAMeBee456K0StqUaVjpHaTO LClcubUWPgm2grmVMAjGiI+WPbG1HkxyVfUwmyn4= Date: Fri, 21 Jul 2023 14:09:27 +0200 From: Greg KH To: Nipun Gupta Cc: linux-kernel@vger.kernel.org, git@amd.com, pieter.jansen-van-vuuren@amd.com, nikhil.agarwal@amd.com, michal.simek@amd.com, abhijit.gangurde@amd.com Subject: Re: [PATCH v2] cdx: add support for bus mastering Message-ID: <2023072116-yin-prepaid-ff1a@gregkh> References: <20230721114622.24313-1-nipun.gupta@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230721114622.24313-1-nipun.gupta@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 21, 2023 at 05:16:22PM +0530, Nipun Gupta wrote: > Introduce cdx_set_master() and cdx_clear_master() APIs to support > enable and disable of bus mastering. Drivers need to use these APIs to > enable/disable DMAs from the CDX devices. > > Signed-off-by: Nipun Gupta > Reviewed-by: Pieter Jansen van Vuuren > --- > > Changes v1->v2: > - Replace bme with bus_master_enable > - Added check for dev_configure API callback > - remove un-necessary error prints > - changed conditional to if-else > - updated commit message to use 72 columns > > drivers/cdx/cdx.c | 29 +++++++++++++ > drivers/cdx/controller/cdx_controller.c | 4 ++ > drivers/cdx/controller/mcdi_functions.c | 58 +++++++++++++++++++++++++ > drivers/cdx/controller/mcdi_functions.h | 13 ++++++ > include/linux/cdx/cdx_bus.h | 16 +++++++ > 5 files changed, 120 insertions(+) > > diff --git a/drivers/cdx/cdx.c b/drivers/cdx/cdx.c > index d2cad4c670a0..71ddb56a5d08 100644 > --- a/drivers/cdx/cdx.c > +++ b/drivers/cdx/cdx.c > @@ -182,6 +182,35 @@ cdx_match_id(const struct cdx_device_id *ids, struct cdx_device *dev) > return NULL; > } > > +int cdx_set_master(struct cdx_device *cdx_dev) > +{ > + struct cdx_controller *cdx = cdx_dev->cdx; > + struct cdx_device_config dev_config; > + int ret = EOPNOTSUPP; "-EOPNOTSUP"