From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7404EB64DD for ; Fri, 21 Jul 2023 23:00:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231129AbjGUXAN (ORCPT ); Fri, 21 Jul 2023 19:00:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbjGUXAL (ORCPT ); Fri, 21 Jul 2023 19:00:11 -0400 Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9DF93A93 for ; Fri, 21 Jul 2023 16:00:10 -0700 (PDT) Received: by mail-pl1-x649.google.com with SMTP id d9443c01a7336-1b89e3715acso14210425ad.3 for ; Fri, 21 Jul 2023 16:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689980410; x=1690585210; h=cc:to:from:subject:message-id:mime-version:date:reply-to:from:to:cc :subject:date:message-id:reply-to; bh=dRpmM2jj/hlD9zn4KXUWJJ0DXD5l3XPrTy7EQ8BSFM0=; b=R4cXu6oJUn5piVAk+Ojaz/Iff4NUz3w3kQypdkTlKTEAmzcUbg1ZSq/gbQiqbLMj2z yAATYAtjfQ/eH+vbOR01gexXmEaJnId0LkV8KJtQiTcL3rc1PGOGRFOZ+VfIvZJS2O2y v8eafe6JZ/Sm2Rh4U5uG6KbKCZgRMs5ml3zRO3wMtofE3549n4MWdhshri6tKCVbI3oZ MQYpmkcZS4AtA4qcE4XxD/xSoVoEoqopTPrlSF/jvesACRdiK31lE3H3YITFcrTXyOHZ Jvz+1WXhkXSmIW2zQF0KByfrQhDd9ij9hULCbB2UfoekPs2iooLM6IMFNJcQ1ceoco4R O2Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689980410; x=1690585210; h=cc:to:from:subject:message-id:mime-version:date:reply-to :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dRpmM2jj/hlD9zn4KXUWJJ0DXD5l3XPrTy7EQ8BSFM0=; b=iLU/RlnTLZjDLJPzQRYtX9Ps3ZyFBfy8x1HQl1HHwkOj6pJQtmQkAnH4lA53B8U7Uv e/CLjmgQF3R4LNVM0zjY3lBdhQrEwf62Ze5C0GyuFSzjlPAuaOLL0hBSYUS5/dcG9mx6 97RqAEzfWvFfD0URApHjKSiIU2weS8YX3rtZhujNKfdtYuT97oWNwNKo9BTvlB4lsOqP IIe2CyaVNEpn4oNzsONTmcWbhAYjQ8pnoEajWZeaFMgbo2iy3ylRvlJ0Ik/WKn5ZzvxV Kc3vRyTw0CMJ641P3YNap4i6RTVcz7iEJoFZtn9ldj1ZqRSjxZMw/lnqfobR9rFbXnsB FV9g== X-Gm-Message-State: ABy/qLbACU+R1WPbDYlrOKpBjtpezDNCk+PxnboTHpqashR52MVzwazv q2lKXA6aiqUdCgPNGNrCM1rmVzAFB+Q= X-Google-Smtp-Source: APBJJlGh5bZf5WqK6t5lO8L4JKMy25XH31t2i60fPlyMSg5DS2TejZYnahjUpeYy7Mt2nMCplUVTk4oiiFQ= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:903:1c9:b0:1b9:df8f:888c with SMTP id e9-20020a17090301c900b001b9df8f888cmr11726plh.8.1689980410094; Fri, 21 Jul 2023 16:00:10 -0700 (PDT) Reply-To: Sean Christopherson Date: Fri, 21 Jul 2023 15:59:57 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog Message-ID: <20230721230006.2337941-1-seanjc@google.com> Subject: [PATCH v2 0/9] KVM: x86/mmu: Clean up MMU_DEBUG and BUG/WARN usage From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Mingwei Zhang , David Matlack , Jim Mattson Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series consist of three loosely related miniseries: 1. Remove the noisy prints buried behind MMU_DEBUG, and replace MMU_DEBUG with a KVM_PROVE_MMU Kconfig. 2. Use WARN_ON_ONCE() for all runtime WARNs, i.e. avoid spamming the kernel log if something goes awry in the MMU. 3. Demote BUG() usage in the shadow MMU to KVM_BUG_ON() when the kernel is built with CONFIG_BUG_ON_DATA_CORRUPTION=n. v2: - Collect a review. [Mingwei] - Call out the more obvious path to FNAME(walk_addr_generic) in patch 6. [David] - Use BUILD_BUG_ON_INVALID() for the stub. [David] v1: https://lore.kernel.org/all/20230511235917.639770-1-seanjc@google.com Mingwei Zhang (1): KVM: x86/mmu: Plumb "struct kvm" all the way to pte_list_remove() Sean Christopherson (8): KVM: x86/mmu: Delete rmap_printk() and all its usage KVM: x86/mmu: Delete the "dbg" module param KVM: x86/mmu: Rename MMU_WARN_ON() to KVM_MMU_WARN_ON() KVM: x86/mmu: Convert "runtime" WARN_ON() assertions to WARN_ON_ONCE() KVM: x86/mmu: Bug the VM if a vCPU ends up in long mode without PAE enabled KVM: x86/mmu: Replace MMU_DEBUG with proper KVM_PROVE_MMU Kconfig KVM: x86/mmu: Use BUILD_BUG_ON_INVALID() for KVM_MMU_WARN_ON() stub KVM: x86/mmu: BUG() in rmap helpers iff CONFIG_BUG_ON_DATA_CORRUPTION=y arch/x86/kvm/Kconfig | 13 ++++ arch/x86/kvm/mmu/mmu.c | 127 ++++++++++++++------------------ arch/x86/kvm/mmu/mmu_internal.h | 12 +-- arch/x86/kvm/mmu/page_track.c | 16 ++-- arch/x86/kvm/mmu/paging_tmpl.h | 16 +++- arch/x86/kvm/mmu/spte.c | 4 +- arch/x86/kvm/mmu/spte.h | 8 +- arch/x86/kvm/mmu/tdp_iter.c | 4 +- arch/x86/kvm/mmu/tdp_mmu.c | 28 +++---- include/linux/kvm_host.h | 19 +++++ 10 files changed, 134 insertions(+), 113 deletions(-) base-commit: 294ebdda1560d3eb515da88b805ba7f88eb28d21 -- 2.41.0.487.g6d72f3e995-goog