From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77638EB64DC for ; Fri, 21 Jul 2023 14:48:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231556AbjGUOs2 (ORCPT ); Fri, 21 Jul 2023 10:48:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231555AbjGUOsX (ORCPT ); Fri, 21 Jul 2023 10:48:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B44930F0; Fri, 21 Jul 2023 07:48:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F319F61BAF; Fri, 21 Jul 2023 14:48:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0816C433C8; Fri, 21 Jul 2023 14:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689950897; bh=b10pDins9AOW/mh5Q6IYQ22/hzxON084x43peVSYFSA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eNdCKYYvOwE4yYDfN61yVeTI082y1e24LhfB+sz4IVT1W5fIqqYbx4b7VbkHtDLPv 59JLdInkvR+G9ey0T2MmFRelEJVM2X8rf2uvpYEZKR6cVfgzALDG/wUrHcDtV2lHXo bsuTvHuk27Gz2crvL7xI2eRTMGI2X68q9ExmE2nkaeoyPL4s7xl1dEvRMOfjVVbH8p 8xrtex6OuFr4Uoe99KdfWcR2j3AZiCPy9BJe4CKvvsYp7c8iga17uZ8zrtjvnq7MKT RgBHvpdewrMrsanLfhbMFA5vUMPbzthaVZoeTcOMnqP7JZsCqI84ua2CkmOL+cVS7l vuaUIM63i8nOQ== Date: Fri, 21 Jul 2023 23:48:11 +0900 From: Masami Hiramatsu (Google) To: Arnaldo Carvalho de Melo Cc: Namhyung Kim , Ingo Molnar , Thomas Gleixner , Jiri Olsa , Ian Rogers , Adrian Hunter , Clark Williams , Kate Carcia , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Andre Fredette , Dave Tucker , Derek Barbosa , Masami Hiramatsu Subject: Re: [PATCH 3/5] perf bench uprobe: Show diff to previous Message-Id: <20230721234811.a17eea2982501a7dce8e6152@kernel.org> In-Reply-To: <20230719204910.539044-4-acme@kernel.org> References: <20230719204910.539044-1-acme@kernel.org> <20230719204910.539044-4-acme@kernel.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Jul 2023 17:49:08 -0300 Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo > > Will be useful to show the incremental overhead as we do more stuff in > the BPF program attached to the uprobes. Looks good to me. Reviewed-by: Masami Hiramatsu (Google) BTW, bench_uprobe_format__default_fprintf() looks like generic for micro benchmarks. Can it be shared with other benchmarks? Thank you, > > Cc: Adrian Hunter > Cc: Andre Fredette > Cc: Clark Williams > Cc: Dave Tucker > Cc: Derek Barbosa > Cc: Ian Rogers > Cc: Jiri Olsa > Cc: Masami Hiramatsu (Google) > Cc: Namhyung Kim > Signed-off-by: Arnaldo Carvalho de Melo > --- > tools/perf/bench/uprobe.c | 21 ++++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-) > > diff --git a/tools/perf/bench/uprobe.c b/tools/perf/bench/uprobe.c > index 60e7c43298d8cf56..a90e09f791c540a9 100644 > --- a/tools/perf/bench/uprobe.c > +++ b/tools/perf/bench/uprobe.c > @@ -36,24 +36,35 @@ static const char * const bench_uprobe_usage[] = { > > static int bench_uprobe_format__default_fprintf(const char *name, const char *unit, u64 diff, FILE *fp) > { > - static u64 baseline; > - s64 diff_to_baseline = diff - baseline; > + static u64 baseline, previous; > + s64 diff_to_baseline = diff - baseline, > + diff_to_previous = diff - previous; > int printed = fprintf(fp, "# Executed %'d %s calls\n", loops, name); > > printed += fprintf(fp, " %14s: %'" PRIu64 " %ss", "Total time", diff, unit); > > - if (baseline) > + if (baseline) { > printed += fprintf(fp, " %s%'" PRId64 " to baseline", diff_to_baseline > 0 ? "+" : "", diff_to_baseline); > > + if (previous != baseline) > + fprintf(stdout, " %s%'" PRId64 " to previous", diff_to_previous > 0 ? "+" : "", diff_to_previous); > + } > + > printed += fprintf(fp, "\n\n %'.3f %ss/op", (double)diff / (double)loops, unit); > > - if (baseline) > + if (baseline) { > printed += fprintf(fp, " %'.3f %ss/op to baseline", (double)diff_to_baseline / (double)loops, unit); > - else > + > + if (previous != baseline) > + printed += fprintf(fp, " %'.3f %ss/op to previous", (double)diff_to_previous / (double)loops, unit); > + } else { > baseline = diff; > + } > > fputc('\n', fp); > > + previous = diff; > + > return printed + 1; > } > > -- > 2.41.0 > -- Masami Hiramatsu (Google)