From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64B8AC0015E for ; Sat, 22 Jul 2023 18:08:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229702AbjGVSH4 (ORCPT ); Sat, 22 Jul 2023 14:07:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229569AbjGVSHy (ORCPT ); Sat, 22 Jul 2023 14:07:54 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 052132137 for ; Sat, 22 Jul 2023 11:07:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Content-Type:Mime-Version: References:In-Reply-To:Message-Id:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=m9ibkvVetKnPgi6edUxyjCX+2jN94mCaaKhYLkGKRJI=; b=a1RBYg5cbsNdT8livfdgxdjmBP cXfkOQmosixCa9GvF0aup1zOvq83kylMXkxqSDOxYTZD9BUBF4YkQwrIJDqlyJueZdfBWcvj6YeZf XRR/vZofN/4uXCIbVuf6Z7jpH38odTD4vWRZwdfYp+TnkQ9/viW9YCQHRP5bLMkRshbQ=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61]:38384 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1qNH15-0004Db-MI; Sat, 22 Jul 2023 14:07:44 -0400 Date: Sat, 22 Jul 2023 14:07:43 -0400 From: Hugo Villeneuve To: Miguel Ojeda Cc: me@davidreaver.com, poeschel@lemonage.de, Miguel Ojeda , Hugo Villeneuve , linux-kernel@vger.kernel.org, geert@linux-m68k.org, Christian Meusel Message-Id: <20230722140743.fe710f4f12c344f07d879c88@hugovil.com> In-Reply-To: References: <20230706185100.84322-1-hugo@hugovil.com> <20230706154937.1380bdcf9d84e1cff78911fa@hugovil.com> <7eb2d50baf269310e51854f700936e94@lemonage.de> <86wmysknde.fsf@davidreaver.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 184.161.19.61 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH] auxdisplay: hd44780: move cursor home after clear display command X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 22 Jul 2023 18:04:03 +0200 Miguel Ojeda wrote: > On Sat, Jul 22, 2023 at 4:54 PM David Reaver wrote: > > > > I was actually hooking up a 16x2 HD44780 on my BeagleBone Black last > > night before I came across this patch, so I was able to test this. It > > works fine for me. I tested with: > > > > $ printf '\f' > /dev/lcd > > $ printf 'Hello\nWorld!\n' > /dev/lcd > > $ printf '\x1b[LR' > /dev/lcd > > $ printf '\x1b[LR' > /dev/lcd > > $ printf '\x1b[LR' > /dev/lcd > > $ printf '\f' > /dev/lcd > > $ printf 'Goodbye\nWorld!\n' > /dev/lcd > > > > As expected, "Goodbye World!" was correctly placed left-aligned on the > > display, split over both lines. Let me know if there is something else > > you would like me to do to test this! > > > > Tested-by: David Reaver > > Thanks a lot, that is very helpful! > > I will wait a while in case Christian or somebody else wants to test > it, and send it for 6.6. Hi Miguel, in the meantime, I will send V2 of the patch with the changes you suggested for the commit message and the comments. Hugo.