From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V4 3/8] firmware: imx: scu: drop return value check
Date: Mon, 24 Jul 2023 14:38:47 +0800 [thread overview]
Message-ID: <20230724063852.2666930-4-peng.fan@oss.nxp.com> (raw)
In-Reply-To: <20230724063852.2666930-1-peng.fan@oss.nxp.com>
From: Peng Fan <peng.fan@nxp.com>
For IMX_SC_MISC_FUNC_UNIQUE_ID, the scfw has a return value,
and the imx-scu always return 0. So drop the return value check.
BTW, also initialize msg to 0.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/firmware/imx/imx-scu-soc.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/firmware/imx/imx-scu-soc.c b/drivers/firmware/imx/imx-scu-soc.c
index 2f32353de2c9..ef9103987e76 100644
--- a/drivers/firmware/imx/imx-scu-soc.c
+++ b/drivers/firmware/imx/imx-scu-soc.c
@@ -33,20 +33,15 @@ struct imx_sc_msg_misc_get_soc_uid {
static int imx_scu_soc_uid(u64 *soc_uid)
{
- struct imx_sc_msg_misc_get_soc_uid msg;
+ struct imx_sc_msg_misc_get_soc_uid msg = { 0 };
struct imx_sc_rpc_msg *hdr = &msg.hdr;
- int ret;
hdr->ver = IMX_SC_RPC_VERSION;
hdr->svc = IMX_SC_RPC_SVC_MISC;
hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID;
hdr->size = 1;
- ret = imx_scu_call_rpc(imx_sc_soc_ipc_handle, &msg, true);
- if (ret) {
- pr_err("%s: get soc uid failed, ret %d\n", __func__, ret);
- return ret;
- }
+ imx_scu_call_rpc(imx_sc_soc_ipc_handle, &msg, true);
*soc_uid = msg.uid_high;
*soc_uid <<= 32;
--
2.37.1
next prev parent reply other threads:[~2023-07-24 6:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 6:38 [PATCH V4 0/8] firmware: imx: scu/scu-irq: misc update Peng Fan (OSS)
2023-07-24 6:38 ` [PATCH V4 1/8] firmware: imx: scu: change init level to subsys_initcall_sync Peng Fan (OSS)
2023-07-24 6:38 ` [PATCH V4 2/8] firmware: imx: scu: increase RPC timeout Peng Fan (OSS)
2023-07-24 6:38 ` Peng Fan (OSS) [this message]
2023-07-24 6:38 ` [PATCH V4 4/8] firmware: imx: scu: use soc name for soc_id Peng Fan (OSS)
2023-07-24 6:38 ` [PATCH V4 5/8] firmware: imx: scu-irq: fix RCU complains after M4 partition reset Peng Fan (OSS)
2023-07-24 6:38 ` [PATCH V4 6/8] firmware: imx: scu-irq: export imx_scu_irq_get_status Peng Fan (OSS)
2023-07-24 6:38 ` [PATCH V4 7/8] firmware: imx: scu-irq: enlarge the IMX_SC_IRQ_NUM_GROUP Peng Fan (OSS)
2023-07-24 6:38 ` [PATCH V4 8/8] firmware: imx: scu-irq: support identifying SCU wakeup source from sysfs Peng Fan (OSS)
2023-07-26 10:42 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724063852.2666930-4-peng.fan@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®