mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Andrew Cooper <andrew.cooper3@citrix.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Wei Liu <wei.liu@kernel.org>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Juergen Gross <jgross@suse.com>,
	Michael Kelley <mikelley@microsoft.com>,
	Peter Keresztes Schmidt <peter@keresztesschmidt.de>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: [patch V2 53/58] x86/apic: Convert other overrides to apic_update_callback()
Date: Mon, 24 Jul 2023 15:35:16 +0200 (CEST)	[thread overview]
Message-ID: <20230724132047.723609015@linutronix.de> (raw)
In-Reply-To: <20230724131206.500814398@linutronix.de>

Convert all places which just assign a new function directly to the apic
callback to use apic_update_callback() which prepares for using static
calls.

Mark snp_set_wakeup_secondary_cpu() and kvm_setup_pv_ipi() __init, as they
are only invoked from init code and otherwise trigger a section mismatch as
they are now invoking a __init function.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
V2: Mark snp_set_wakeup_secondary_cpu() and kvm_setup_pv_ipi() __init.
---
 arch/x86/hyperv/hv_apic.c |   20 ++++++++++----------
 arch/x86/kernel/kvm.c     |    6 +++---
 arch/x86/kernel/sev.c     |    4 ++--
 3 files changed, 15 insertions(+), 15 deletions(-)

--- a/arch/x86/hyperv/hv_apic.c
+++ b/arch/x86/hyperv/hv_apic.c
@@ -288,12 +288,12 @@ void __init hv_apic_init(void)
 		 */
 		orig_apic = *apic;
 
-		apic->send_IPI = hv_send_ipi;
-		apic->send_IPI_mask = hv_send_ipi_mask;
-		apic->send_IPI_mask_allbutself = hv_send_ipi_mask_allbutself;
-		apic->send_IPI_allbutself = hv_send_ipi_allbutself;
-		apic->send_IPI_all = hv_send_ipi_all;
-		apic->send_IPI_self = hv_send_ipi_self;
+		apic_update_callback(send_IPI, hv_send_ipi);
+		apic_update_callback(send_IPI_mask, hv_send_ipi_mask);
+		apic_update_callback(send_IPI_mask_allbutself, hv_send_ipi_mask_allbutself);
+		apic_update_callback(send_IPI_allbutself, hv_send_ipi_allbutself);
+		apic_update_callback(send_IPI_all, hv_send_ipi_all);
+		apic_update_callback(send_IPI_self, hv_send_ipi_self);
 	}
 
 	if (ms_hyperv.hints & HV_X64_APIC_ACCESS_RECOMMENDED) {
@@ -312,10 +312,10 @@ void __init hv_apic_init(void)
 		 */
 		apic_update_callback(eoi, hv_apic_eoi_write);
 		if (!x2apic_enabled()) {
-			apic->read      = hv_apic_read;
-			apic->write     = hv_apic_write;
-			apic->icr_write = hv_apic_icr_write;
-			apic->icr_read  = hv_apic_icr_read;
+			apic_update_callback(read, hv_apic_read);
+			apic_update_callback(write, hv_apic_write);
+			apic_update_callback(icr_write, hv_apic_icr_write);
+			apic_update_callback(icr_read, hv_apic_icr_read);
 		}
 	}
 }
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -622,10 +622,10 @@ late_initcall(setup_efi_kvm_sev_migratio
 /*
  * Set the IPI entry points
  */
-static void kvm_setup_pv_ipi(void)
+static __init void kvm_setup_pv_ipi(void)
 {
-	apic->send_IPI_mask = kvm_send_ipi_mask;
-	apic->send_IPI_mask_allbutself = kvm_send_ipi_mask_allbutself;
+	apic_update_callback(send_IPI_mask, kvm_send_ipi_mask);
+	apic_update_callback(send_IPI_mask_allbutself, kvm_send_ipi_mask_allbutself);
 	pr_info("setup PV IPIs\n");
 }
 
--- a/arch/x86/kernel/sev.c
+++ b/arch/x86/kernel/sev.c
@@ -1089,7 +1089,7 @@ static int wakeup_cpu_via_vmgexit(int ap
 	return ret;
 }
 
-void snp_set_wakeup_secondary_cpu(void)
+void __init snp_set_wakeup_secondary_cpu(void)
 {
 	if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP))
 		return;
@@ -1099,7 +1099,7 @@ void snp_set_wakeup_secondary_cpu(void)
 	 * required method to start APs under SNP. If the hypervisor does
 	 * not support AP creation, then no APs will be started.
 	 */
-	apic->wakeup_secondary_cpu = wakeup_cpu_via_vmgexit;
+	apic_update_callback(wakeup_secondary_cpu, wakeup_cpu_via_vmgexit);
 }
 
 int __init sev_es_setup_ap_jump_table(struct real_mode_header *rmh)


  parent reply	other threads:[~2023-07-24 13:45 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-24 13:33 [patch V2 00/58] x86/apic: Decrapification and static calls Thomas Gleixner
2023-07-24 13:33 ` [patch V2 01/58] x86/cpu: Make identify_boot_cpu() static Thomas Gleixner
2023-07-24 13:33 ` [patch V2 02/58] x86/cpu: Remove unused physid_*() nonsense Thomas Gleixner
2023-07-24 13:33 ` [patch V2 03/58] x86/apic: Rename disable_apic Thomas Gleixner
2023-07-24 13:33 ` [patch V2 04/58] x86/apic/ioapic: Rename skip_ioapic_setup Thomas Gleixner
2023-07-24 13:33 ` [patch V2 05/58] x86/apic: Remove pointless x86_bios_cpu_apicid Thomas Gleixner
2023-07-24 13:33 ` [patch V2 06/58] x86/apic: Get rid of hard_smp_processor_id() Thomas Gleixner
2023-07-24 13:33 ` [patch V2 07/58] x86/apic: Remove unused max_physical_apicid Thomas Gleixner
2023-07-24 13:33 ` [patch V2 08/58] x86/apic: Nuke unused apic::inquire_remote_apic() Thomas Gleixner
2023-07-24 13:33 ` [patch V2 09/58] x86/apic: Get rid of boot_cpu_physical_apicid madness Thomas Gleixner
2023-07-24 13:34 ` [patch V2 10/58] x86/apic: Register boot CPU APIC early Thomas Gleixner
2023-07-24 13:34 ` [patch V2 11/58] x86/apic: Remove the pointless APIC version check Thomas Gleixner
2023-07-24 13:34 ` [patch V2 12/58] x86/of: Fix the APIC address registration Thomas Gleixner
2023-07-24 13:34 ` [patch V2 13/58] x86/apic: Make some APIC init functions bool Thomas Gleixner
2023-07-24 13:34 ` [patch V2 14/58] x86/apic: Split register_apic_address() Thomas Gleixner
2023-07-24 13:34 ` [patch V2 15/58] x86/apic: Sanitize APIC address setup Thomas Gleixner
2023-07-24 13:34 ` [patch V2 16/58] x86/apic: Sanitize num_processors handling Thomas Gleixner
2023-07-31 10:17   ` Juergen Gross
2023-07-31 12:50     ` Thomas Gleixner
2023-07-31 15:57       ` Thomas Gleixner
2023-07-31 18:19         ` Juergen Gross
2023-08-01  6:12           ` Juergen Gross
2023-07-24 13:34 ` [patch V2 17/58] x86/apic: Nuke another processor check Thomas Gleixner
2023-07-24 13:34 ` [patch V2 18/58] x86/apic: Remove check_phys_apicid_present() Thomas Gleixner
2023-07-24 13:34 ` [patch V2 19/58] x86/apic: Get rid of apic_phys Thomas Gleixner
2023-07-24 13:34 ` [patch V2 20/58] x86/apic/32: Sanitize logical APIC ID handling Thomas Gleixner
2023-07-24 13:34 ` [patch V2 21/58] x86/apic/32: Remove x86_cpu_to_logical_apicid Thomas Gleixner
2023-07-24 13:34 ` [patch V2 22/58] x86/apic/ipi: Code cleanup Thomas Gleixner
2023-07-24 13:34 ` [patch V2 23/58] x86/apic: Mop up early_per_cpu() abuse Thomas Gleixner
2023-07-24 13:34 ` [patch V2 24/58] x86/apic/32: Remove pointless default_acpi_madt_oem_check() Thomas Gleixner
2023-07-24 13:34 ` [patch V2 25/58] x86/apic/32: Decrapify the def_bigsmp mechanism Thomas Gleixner
2023-07-24 13:34 ` [patch V2 26/58] x86/apic/32: Remove bigsmp_cpu_present_to_apicid() Thomas Gleixner
2023-07-24 13:34 ` [patch V2 27/58] x86/apic: Nuke empty init_apic_ldr() callbacks Thomas Gleixner
2023-07-24 13:34 ` [patch V2 28/58] x86/apic: Nuke apic::apicid_to_cpu_present() Thomas Gleixner
2023-07-24 13:34 ` [patch V2 29/58] x86/ioapic/32: Decrapify phys_id_present_map operation Thomas Gleixner
2023-07-24 13:34 ` [patch V2 30/58] x86/apic: Mop up *setup_apic_routing() Thomas Gleixner
2023-07-24 13:34 ` [patch V2 31/58] x86/apic: Mop up apic::apic_id_registered() Thomas Gleixner
2023-07-24 13:34 ` [patch V2 32/58] x86/apic/ipi: Tidy up the code and fixup comments Thomas Gleixner
2023-07-24 13:34 ` [patch V2 33/58] x86/apic: Consolidate wait_icr_idle() implementations Thomas Gleixner
2023-07-24 13:34 ` [patch V2 34/58] x86/apic: Allow apic::wait_icr_idle() to be NULL Thomas Gleixner
2023-07-24 13:34 ` [patch V2 35/58] x86/apic: Allow apic::safe_wait_icr_idle() " Thomas Gleixner
2023-07-24 13:34 ` [patch V2 36/58] x86/apic: Move safe wait_icr_idle() next to apic_mem_wait_icr_idle() Thomas Gleixner
2023-07-24 13:34 ` [patch V2 37/58] x86/apic/uv: Get rid of wrapper callbacks Thomas Gleixner
2023-07-24 13:34 ` [patch V2 38/58] x86/apic/x2apic: Share all common IPI functions Thomas Gleixner
2023-07-24 13:34 ` [patch V2 39/58] x86/apic/64: Uncopypaste probing Thomas Gleixner
2023-07-24 13:34 ` [patch V2 40/58] x86/apic: Wrap APIC ID validation into an inline Thomas Gleixner
2023-07-24 13:34 ` [patch V2 41/58] x86/apic: Add max_apic_id member Thomas Gleixner
2023-07-24 13:34 ` [patch V2 42/58] x86/apic: Simplify X2APIC ID validation Thomas Gleixner
2023-07-24 13:34 ` [patch V2 43/58] x86/apic: Prepare x2APIC for using apic::max_apic_id Thomas Gleixner
2023-07-24 13:35 ` [patch V2 44/58] x86/apic: Sanitize APID ID range validation Thomas Gleixner
2023-07-24 13:35 ` [patch V2 45/58] x86/apic: Remove pointless NULL initializations Thomas Gleixner
2023-07-24 13:35 ` [patch V2 46/58] x86/apic/noop: Tidy up the code Thomas Gleixner
2023-07-24 13:35 ` [patch V2 47/58] x86/apic: Remove pointless arguments from [native_]eoi_write() Thomas Gleixner
2023-07-24 13:35 ` [patch V2 48/58] x86/apic: Nuke ack_APIC_irq() Thomas Gleixner
2023-07-24 13:35 ` [patch V2 49/58] x86/apic: Wrap apic->native_eoi() into a helper Thomas Gleixner
2023-07-24 13:35 ` [patch V2 50/58] x86/apic: Provide common init infrastructure Thomas Gleixner
2023-07-31 11:31   ` Juergen Gross
2023-07-31 13:01     ` Thomas Gleixner
2023-07-31 13:10       ` Juergen Gross
2023-07-31 15:48         ` Thomas Gleixner
2023-08-01  6:41           ` Thomas Gleixner
2023-08-01  6:49             ` Juergen Gross
2023-08-01  7:08               ` Juergen Gross
2023-08-01  7:32                 ` Thomas Gleixner
2023-08-01  7:37                   ` Juergen Gross
2023-08-01  8:23                     ` Thomas Gleixner
2023-08-01  8:25                       ` Juergen Gross
2023-08-01  8:54                         ` Thomas Gleixner
2023-08-01  8:59                           ` Juergen Gross
2023-08-09 20:36                             ` [tip: x86/apic] x86/xen/apic: Use standard apic driver mechanism for Xen PV tip-bot2 for Juergen Gross
2023-08-01  7:30             ` [patch V2 50/58] x86/apic: Provide common init infrastructure Thomas Gleixner
2023-07-24 13:35 ` [patch V2 51/58] x86/apic: Provide apic_update_callback() Thomas Gleixner
2023-07-24 13:35 ` [patch V2 52/58] x86/apic: Replace acpi_wake_cpu_handler_update() and apic_set_eoi_cb() Thomas Gleixner
2023-07-24 13:35 ` Thomas Gleixner [this message]
2023-07-24 13:35 ` [patch V2 54/58] x86/xen/apic: Mark apic __ro_after_init Thomas Gleixner
2023-07-24 13:35 ` [patch V2 55/58] x86/apic: Mark all hotpath APIC callback wrappers __always_inline Thomas Gleixner
2023-07-24 13:35 ` [patch V2 56/58] x86/apic: Wrap IPI calls into helper functions Thomas Gleixner
2023-07-24 13:35 ` [patch V2 57/58] x86/apic: Provide static call infrastructure for APIC callbacks Thomas Gleixner
2023-07-24 13:35 ` [patch V2 58/58] x86/apic: Turn on static calls Thomas Gleixner
2023-07-25  0:40 ` [patch V2 00/58] x86/apic: Decrapification and " Sohil Mehta
2023-07-31 12:20 ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230724132047.723609015@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=andrew.cooper3@citrix.com \
    --cc=arjan@linux.intel.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=pbonzini@redhat.com \
    --cc=peter@keresztesschmidt.de \
    --cc=peterz@infradead.org \
    --cc=thomas.lendacky@amd.com \
    --cc=wei.liu@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome