From: Davidlohr Bueso <dave@stgolabs.net>
To: peterz@infradead.org, mingo@kernel.org
Cc: dave@stgolabs.net, linux-kernel@vger.kernel.org
Subject: [PATCH] rcuwait: Add might_sleep() annotations
Date: Mon, 24 Jul 2023 09:03:36 -0700 [thread overview]
Message-ID: <20230724160337.20851-1-dave@stgolabs.net> (raw)
... as with regular waitqueues.
Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
---
include/linux/rcuwait.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/include/linux/rcuwait.h b/include/linux/rcuwait.h
index 27343424225c..c0fcac903d03 100644
--- a/include/linux/rcuwait.h
+++ b/include/linux/rcuwait.h
@@ -74,7 +74,10 @@ extern void finish_rcuwait(struct rcuwait *w);
})
#define rcuwait_wait_event(w, condition, state) \
- ___rcuwait_wait_event(w, condition, state, 0, schedule())
+do { \
+ might_sleep(); \
+ ___rcuwait_wait_event(w, condition, state, 0, schedule()); \
+} while (0)
#define __rcuwait_wait_event_timeout(w, condition, state, timeout) \
___rcuwait_wait_event(w, ___wait_cond_timeout(condition), \
@@ -84,6 +87,7 @@ extern void finish_rcuwait(struct rcuwait *w);
#define rcuwait_wait_event_timeout(w, condition, state, timeout) \
({ \
long __ret = timeout; \
+ might_sleep(); \
if (!___wait_cond_timeout(condition)) \
__ret = __rcuwait_wait_event_timeout(w, condition, \
state, timeout); \
--
2.41.0
next reply other threads:[~2023-07-24 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 16:03 Davidlohr Bueso [this message]
2023-07-25 12:03 ` Peter Zijlstra
2023-07-25 14:27 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724160337.20851-1-dave@stgolabs.net \
--to=dave@stgolabs.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®