mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qais Yousef <qyousef@layalina.io>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] sched/fair: Fix impossible migrate_util scenario in load balance
Date: Mon, 24 Jul 2023 22:11:50 +0100	[thread overview]
Message-ID: <20230724211150.lc5dlxlbewxwr5rb@airbuntu> (raw)
In-Reply-To: <1e675286-b4b8-5abd-dd4c-3f2ffdaf12c1@arm.com>

On 07/24/23 19:54, Dietmar Eggemann wrote:
> On 24/07/2023 18:10, Qais Yousef wrote:
> > On 07/24/23 14:58, Dietmar Eggemann wrote:
> >> On 22/07/2023 00:04, Qais Yousef wrote:
> >>> On 07/21/23 15:52, Vincent Guittot wrote:
> >>>> Le vendredi 21 juil. 2023 à 11:57:11 (+0100), Qais Yousef a écrit :
> >>>>> On 07/20/23 14:31, Vincent Guittot wrote:
> 
> [...]
> 
> > So I actually moved everything to a single cluster and this indeed solves the
> > lb() issue. But then when I tried to look at DT mainline I saw that the DTs
> > still define separate cluster for each uArch, and this got me confused whether
> > I did the right thing or not. And made me wonder whether the fix is to change
> > DT or port Sudeep's/Ionela's patch?
> 
> IMHO, you have to change DT.
> 
> > I did some digging and I think the DT, like the ones in mainline by the look of
> > it, stayed the way it was historically defined.
> 
> This would be a "mistake" for Arm DynamIQ based systems. We use QC RB5
> in our testing and this board schedules only within a MC sched domain (I
> guess it's: arch/arm64/boot/dts/qcom/qrb5165-rb5.dts -> sm8250.dtsi)

I did find some qcom platforms that define a single cluster after I sent my
email. Not sure if the ones I've looked at were having wrong definitions or
not.

Anyway, hope this discussion will enlighten others too ;-)


Cheers

--
Qais Yousef

      reply	other threads:[~2023-07-24 21:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-16  1:41 Qais Yousef
2023-07-18 12:48 ` Vincent Guittot
2023-07-18 16:18   ` Qais Yousef
2023-07-18 16:31     ` Vincent Guittot
2023-07-18 17:25       ` Qais Yousef
2023-07-20 12:31         ` Vincent Guittot
2023-07-21 10:57           ` Qais Yousef
2023-07-21 13:52             ` Vincent Guittot
2023-07-21 22:04               ` Qais Yousef
2023-07-24 12:58                 ` Dietmar Eggemann
2023-07-24 16:10                   ` Qais Yousef
2023-07-24 17:54                     ` Dietmar Eggemann
2023-07-24 21:11                       ` Qais Yousef [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230724211150.lc5dlxlbewxwr5rb@airbuntu \
    --to=qyousef@layalina.io \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®