From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
John Stultz <jstultz@google.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/2] scripts/faddr2line: Ignore non-function symbols in readelf output
Date: Mon, 24 Jul 2023 16:47:34 -0700 [thread overview]
Message-ID: <20230724234734.zy67gm674vl3p3wv@treble> (raw)
In-Reply-To: <20230724174517.15736-2-will@kernel.org>
On Mon, Jul 24, 2023 at 06:45:16PM +0100, Will Deacon wrote:
> Non-function symbols emitted in the readelf output can confuse the
> 'faddr2line' symbol size calculation, resulting in the erroneous
> rejection of valid offsets. This is especially prevalent when building
> an arm64 kernel with CONFIG_CFI_CLANG=y, where most functions are
> prefixed with a 32-bit data value in a '$d.n' section. For example:
>
> 447538: ffff800080014b80 548 FUNC GLOBAL DEFAULT 2 do_one_initcall
> 104: ffff800080014c74 0 NOTYPE LOCAL DEFAULT 2 $x.73
> 106: ffff800080014d30 0 NOTYPE LOCAL DEFAULT 2 $x.75
> 111: ffff800080014da4 0 NOTYPE LOCAL DEFAULT 2 $d.78
> 112: ffff800080014da8 0 NOTYPE LOCAL DEFAULT 2 $x.79
> 36: ffff800080014de0 200 FUNC LOCAL DEFAULT 2 run_init_process
>
> Adding a warning to do_one_initcall() results in:
>
> | WARNING: CPU: 0 PID: 1 at init/main.c:1236 do_one_initcall+0xf4/0x260
>
> Which 'faddr2line' refuses to accept:
>
> $ ./scripts/faddr2line vmlinux do_one_initcall+0xf4/0x260
> skipping do_one_initcall address at 0xffff800080014c74 due to size mismatch (0x260 != 0x224)
> no match for do_one_initcall+0xf4/0x260
>
> Filter out entries from readelf that are not "FUNC" type, so that the
> size of a symbol is calculated as a delta to the next function address.
Problem is, I think the kernel's symbol printing code prints the nearest
kallsyms symbol, and there are some valid non-FUNC code symbols. For
example, syscall_return_via_sysret. This patch would cause those valid
symbols to get missed.
I presume these '$x.*' symbols don't end up in System.map? How do they
get filtered out? By the linker maybe?
We may want to use whatever criteria used there, e.g. have faddr2line
ignore symbols starting with '$' or so?
--
Josh
next prev parent reply other threads:[~2023-07-24 23:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 17:45 [PATCH 0/2] Fix 'faddr2line' for LLVM arm64 builds Will Deacon
2023-07-24 17:45 ` [PATCH 1/2] scripts/faddr2line: Ignore non-function symbols in readelf output Will Deacon
2023-07-24 23:47 ` Josh Poimboeuf [this message]
2023-07-25 17:21 ` Will Deacon
2023-10-24 8:52 ` [tip: objtool/core] scripts/faddr2line: Don't filter out non-function symbols from readelf tip-bot2 for Will Deacon
2023-07-24 17:45 ` [PATCH 2/2] scripts/faddr2line: Use LLVM addr2line and readelf if LLVM=1 Will Deacon
2023-07-25 0:07 ` Josh Poimboeuf
2023-07-25 17:21 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724234734.zy67gm674vl3p3wv@treble \
--to=jpoimboe@kernel.org \
--cc=jstultz@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®