From: Fenglin Wu <quic_fenglinw@quicinc.com>
To: Fenglin Wu <quic_fenglinw@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>,
Lee Jones <lee@kernel.org>
Cc: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 0/3] leds-qcom-flash: several tiny fixes
Date: Tue, 25 Jul 2023 17:57:18 +0800 [thread overview]
Message-ID: <20230725-leds-qcom-flash-driver-tiny-fixes-v2-0-0f5cbce5fed0@quicinc.com> (raw)
Add small changes to address the review comments from Paval which were
posted after the driver was applied:
https://lore.kernel.org/linux-arm-msm/20230325170957.GA2904@bug/#t
https://lore.kernel.org/linux-arm-msm/ZB8wbv93+Vmx3trt@duo.ucw.cz/
1) Add a sentence in Kconfig to explain the driver can be compiled as a
module
2) Strobe off the LED channel before setting flash current
3) Put the child node while register flash LED device failed.
Changes in v2:
Sperate the fixes into 3 independent changes.
Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
---
Fenglin Wu (3):
leds: flash: leds-qcom-flash: declare the driver as a module
leds: flash: leds-qcom-flash: turn off LED before setting flash current
leds: flash: leds-qcom-flash: put child node if registration failed
drivers/leds/flash/Kconfig | 2 ++
drivers/leds/flash/leds-qcom-flash.c | 5 +++++
2 files changed, 7 insertions(+)
---
base-commit: 7a2b85a76b05f16e8e788d035afcacdd4faa1d71
change-id: 20230725-leds-qcom-flash-driver-tiny-fixes-f6fd8d90eb94
Best regards,
--
Fenglin Wu <quic_fenglinw@quicinc.com>
next reply other threads:[~2023-07-25 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 9:57 Fenglin Wu [this message]
2023-07-25 9:57 ` [PATCH v2 1/3] leds: flash: leds-qcom-flash: declare the driver as a module Fenglin Wu
2023-07-25 9:57 ` [PATCH v2 2/3] leds: flash: leds-qcom-flash: turn off LED before setting flash current Fenglin Wu
2023-07-25 9:57 ` [PATCH v2 3/3] leds: flash: leds-qcom-flash: put child node if registration failed Fenglin Wu
2023-07-28 11:17 ` [PATCH v2 0/3] leds-qcom-flash: several tiny fixes Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725-leds-qcom-flash-driver-tiny-fixes-v2-0-0f5cbce5fed0@quicinc.com \
--to=quic_fenglinw@quicinc.com \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®