From: Sam Ravnborg <sam@ravnborg.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Helge Deller <deller@gmx.de>, Arnd Bergmann <arnd@arndb.de>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: logo: LOGO should depend on FB_CORE i.s.o. FB
Date: Tue, 25 Jul 2023 19:56:39 +0200 [thread overview]
Message-ID: <20230725175639.GC838289@ravnborg.org> (raw)
In-Reply-To: <877cqoj5q5.fsf@minerva.mail-host-address-is-not-set>
Hi Javier,
> >> > menuconfig LOGO
> >> > bool "Bootup logo"
> >> > - depends on FB || SGI_NEWPORT_CONSOLE
> >> > + depends on FB_CORE || SGI_NEWPORT_CONSOLE
> >> > help
> >> > Enable and select frame buffer bootup logos.
> >>
> >> Should then move this option to drivers/video/fbdev/core/Kconfig ?
> >
> > No, all logo options are in their own file.
> >
>
> Yes. I meant to move drivers/video/logo/ to drivers/fbdev/core/logo and to
> source its Kconfig from drivers/fbdev/core/Kconfig, since it now depends
> on FB_CORE.
>
> But I see now that it also depends on SGI_NEWPORT_CONSOLE, so having those
> in drivers/video/logo makes sense indeed.
The SGI_NEWPORT_CONSOLE should be replaced by some ifdef in the
newport_con.c code - to do what other drivers do.
But thats for another day.
Sam
next prev parent reply other threads:[~2023-07-25 17:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 15:52 Geert Uytterhoeven
2023-07-25 16:06 ` Javier Martinez Canillas
2023-07-25 16:23 ` Geert Uytterhoeven
2023-07-25 16:50 ` Javier Martinez Canillas
2023-07-25 17:56 ` Sam Ravnborg [this message]
2023-07-25 18:30 ` Thomas Zimmermann
2023-07-25 19:53 ` Javier Martinez Canillas
2023-07-26 8:35 ` Sam Ravnborg
2023-07-26 8:39 ` Javier Martinez Canillas
2023-07-26 15:51 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725175639.GC838289@ravnborg.org \
--to=sam@ravnborg.org \
--cc=arnd@arndb.de \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®