From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A1D8C001DE for ; Tue, 25 Jul 2023 18:56:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230259AbjGYSz7 (ORCPT ); Tue, 25 Jul 2023 14:55:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbjGYSz5 (ORCPT ); Tue, 25 Jul 2023 14:55:57 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 866EF1BC2; Tue, 25 Jul 2023 11:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690311356; x=1721847356; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZVyS4i+R5tCisp4JnaVX/EGHRJPoy0lk8ITVH6T/ixc=; b=TJZ6OkPEpoH0nzPvXxGeAqns9AwhExUMe5QjTf40nHVfGPy3v4H/6MQn 0PDa1x07LdfmoggYwVpiAhWxe54ZpWpRd/HT4wl4BuPSqwO6oUM/TNfO7 RYK9r/IJogBjCvmCUuyQhZ6jF5lY1vju0PFqJDYxpNmBN053Ovp2pRX0P maP1BOmcvOfZNcG0wgK/WoHK/aLUYiRKUmqojwZ10LrT/918z29iNOrKN dVq3o44t9BMo0U2rpoKpOC9FqLvVWPM1rn8F+zUmHfnoHZ4LZj3Rd+PTr Wh2so5ekA20/dtmWulLAvrZCON7j3dIAJ/z6b7DUYHghyO7lamXMwl2ur Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="434075297" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="434075297" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 11:55:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="816357216" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="816357216" Received: from lkp-server02.sh.intel.com (HELO 953e8cd98f7d) ([10.239.97.151]) by FMSMGA003.fm.intel.com with ESMTP; 25 Jul 2023 11:55:53 -0700 Received: from kbuild by 953e8cd98f7d with local (Exim 4.96) (envelope-from ) id 1qONCK-0000FZ-2I; Tue, 25 Jul 2023 18:55:52 +0000 Date: Wed, 26 Jul 2023 02:54:04 +0800 From: kernel test robot To: Naresh Solanki , Guenter Roeck , Jean Delvare , krzysztof.kozlowski+dt@linaro.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] hwmon: (pmbus/tda38640) Add workaround for bug in SVID mode Message-ID: <202307260241.BetLbnxd-lkp@intel.com> References: <20230725114030.1860571-3-Naresh.Solanki@9elements.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725114030.1860571-3-Naresh.Solanki@9elements.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Naresh, kernel test robot noticed the following build errors: [auto build test ERROR on 55612007f16b5d7b1fb83a7b0f5bb686829db7c7] url: https://github.com/intel-lab-lkp/linux/commits/Naresh-Solanki/hwmon-pmbus-Add-ON_OFF_CONFIG-register-bits/20230725-194318 base: 55612007f16b5d7b1fb83a7b0f5bb686829db7c7 patch link: https://lore.kernel.org/r/20230725114030.1860571-3-Naresh.Solanki%409elements.com patch subject: [PATCH 3/3] hwmon: (pmbus/tda38640) Add workaround for bug in SVID mode config: x86_64-randconfig-x014-20230725 (https://download.01.org/0day-ci/archive/20230726/202307260241.BetLbnxd-lkp@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce: (https://download.01.org/0day-ci/archive/20230726/202307260241.BetLbnxd-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202307260241.BetLbnxd-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/hwmon/pmbus/tda38640.c:118:7: error: use of undeclared identifier 'CONFIG_SENSORS_TDA38640_REGULATOR' if (!CONFIG_SENSORS_TDA38640_REGULATOR || !np || ^ 1 error generated. vim +/CONFIG_SENSORS_TDA38640_REGULATOR +118 drivers/hwmon/pmbus/tda38640.c 106 107 static int tda38640_probe(struct i2c_client *client) 108 { 109 struct device *dev = &client->dev; 110 struct device_node *np = dev_of_node(dev); 111 struct tda38640_data *data; 112 113 data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); 114 if (!data) 115 return -ENOMEM; 116 memcpy(&data->info, &tda38640_info, sizeof(tda38640_info)); 117 > 118 if (!CONFIG_SENSORS_TDA38640_REGULATOR || !np || 119 of_property_read_u32(np, "infineon,en-pin-fixed-level", &data->en_pin_lvl)) 120 return pmbus_do_probe(client, &data->info); 121 122 /* 123 * Apply ON_OFF_CONFIG workaround as enabling the regulator using the 124 * OPERATION register doesn't work in SVID mode. 125 */ 126 data->info.read_byte_data = tda38640_read_byte_data; 127 data->info.write_byte_data = tda38640_write_byte_data; 128 /* 129 * One should configure PMBUS_ON_OFF_CONFIG here, but 130 * PB_ON_OFF_CONFIG_POWERUP_CONTROL, PB_ON_OFF_CONFIG_EN_PIN_REQ and 131 * PB_ON_OFF_CONFIG_EN_PIN_REQ are ignored by the device. 132 * Only PB_ON_OFF_CONFIG_POLARITY_HIGH has an effect. 133 */ 134 135 return pmbus_do_probe(client, &data->info); 136 } 137 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki