From: Zhu Wang <wangzhu9@huawei.com>
To: <mporter@kernel.crashing.org>, <alex.bou9@gmail.com>,
<akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>
Cc: <wangzhu9@huawei.com>
Subject: [PATCH -next] rapidio: fix -Wunused-const-variable= warning
Date: Wed, 26 Jul 2023 18:17:14 +0800 [thread overview]
Message-ID: <20230726101714.169784-1-wangzhu9@huawei.com> (raw)
When building with W=1, the following warning occurs.
drivers/rapidio/rio_cm.c: In function ‘rio_txcq_handler’:
drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
int rc;
Since the variable "rc" is not used in function 'rio_txcq_handler',
so we removed it to remove the warning.
Fixes: b6e8d4aa1110 ("rapidio: add RapidIO channelized messaging driver")
Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
---
drivers/rapidio/rio_cm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
index 49f8d111e546..652e30c03a00 100644
--- a/drivers/rapidio/rio_cm.c
+++ b/drivers/rapidio/rio_cm.c
@@ -670,13 +670,12 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot)
*/
if (!list_empty(&cm->tx_reqs) && (cm->tx_cnt < RIOCM_TX_RING_SIZE)) {
struct tx_req *req, *_req;
- int rc;
list_for_each_entry_safe(req, _req, &cm->tx_reqs, node) {
list_del(&req->node);
cm->tx_buf[cm->tx_slot] = req->buffer;
- rc = rio_add_outb_message(cm->mport, req->rdev, cmbox,
- req->buffer, req->len);
+ rio_add_outb_message(cm->mport, req->rdev, cmbox,
+ req->buffer, req->len);
kfree(req->buffer);
kfree(req);
--
2.17.1
next reply other threads:[~2023-07-26 10:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 10:17 Zhu Wang [this message]
2023-07-26 19:36 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726101714.169784-1-wangzhu9@huawei.com \
--to=wangzhu9@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alex.bou9@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®