From: Daniel Wagner <dwagner@suse.de>
To: linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Chaitanya Kulkarni <kch@nvidia.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Hannes Reinecke <hare@suse.de>, Sagi Grimberg <sagi@grimberg.me>,
James Smart <jsmart2021@gmail.com>,
Daniel Wagner <dwagner@suse.de>
Subject: [PATCH blktests v1 00/11] Switch to allowed_host
Date: Wed, 26 Jul 2023 14:46:33 +0200 [thread overview]
Message-ID: <20230726124644.12619-1-dwagner@suse.de> (raw)
Max asked me to replace replace the 'nvme/rc: Avoid triggering host nvme-cli
autoconnect' feature with using allowed_host on the target side [1]
So while looking into this new feature, I first started to refactor existing
code so that it looks a bit more consistent. I think there is even more
potential to make it smaller, by introducing something similiar to
_nvmet_passthru_target_setup() and _nvmet_passthru_target_cleanup() for non
passthru tests. A lot of duplicated setup/cleanup code in many tests.
Except the last two patches are just refactoring patches. So if we decide to use
common target setup/cleanup helpers, I think we could add them before the last
two patches, which would make the last patch way smaller.
Daniel
[1] https://lore.kernel.org/all/4b17be94-d068-f026-756f-59208075e254@nvidia.com/
Daniel Wagner (11):
nvme/{003,004,005,013,046,049}: Group all variables declarations
nvme: Reorganize test preamble code section
nvme/rc: Add common subsystem nqn define
nvme: Use def_subsysnqn variable instead local variable
nvme/{041,042,043,044,045,048}: Remove local variable hostnqn and
hostid
nvme/rc: Add common file_path name define
nvme: Use def_file_path variable instead local variable
nvme/rc: Add common def_subsys_uuid define
nvme: Use def_subsys_uuid variable
nvme/rc: Add helper for adding/removing to allow list
nvme: Add explicitly host to allow_host list
tests/nvme/003 | 11 ++++----
tests/nvme/004 | 27 +++++++++++---------
tests/nvme/005 | 27 +++++++++++---------
tests/nvme/006 | 21 ++++++++-------
tests/nvme/007 | 20 ++++++---------
tests/nvme/008 | 26 +++++++++----------
tests/nvme/009 | 24 +++++++++---------
tests/nvme/010 | 26 +++++++++----------
tests/nvme/011 | 25 +++++++++---------
tests/nvme/012 | 26 +++++++++----------
tests/nvme/013 | 25 +++++++++---------
tests/nvme/014 | 26 +++++++++----------
tests/nvme/015 | 24 +++++++++---------
tests/nvme/016 | 17 ++++++-------
tests/nvme/017 | 26 ++++++++-----------
tests/nvme/018 | 24 +++++++++---------
tests/nvme/019 | 26 +++++++++----------
tests/nvme/020 | 24 +++++++++---------
tests/nvme/021 | 24 +++++++++---------
tests/nvme/022 | 24 +++++++++---------
tests/nvme/023 | 26 +++++++++----------
tests/nvme/024 | 24 +++++++++---------
tests/nvme/025 | 24 +++++++++---------
tests/nvme/026 | 24 +++++++++---------
tests/nvme/027 | 24 +++++++++---------
tests/nvme/028 | 24 +++++++++---------
tests/nvme/029 | 26 +++++++++----------
tests/nvme/030 | 19 +++++++-------
tests/nvme/031 | 14 +++++-----
tests/nvme/033 | 9 ++++---
tests/nvme/034 | 9 ++++---
tests/nvme/035 | 9 ++++---
tests/nvme/036 | 9 ++++---
tests/nvme/037 | 8 +++---
tests/nvme/038 | 6 ++---
tests/nvme/039 | 4 +--
tests/nvme/040 | 30 ++++++++++++----------
tests/nvme/041 | 50 ++++++++++++++++--------------------
tests/nvme/042 | 55 ++++++++++++++++++----------------------
tests/nvme/043 | 52 +++++++++++++++++--------------------
tests/nvme/044 | 69 +++++++++++++++++++++++---------------------------
tests/nvme/045 | 61 ++++++++++++++++++++------------------------
tests/nvme/046 | 1 +
tests/nvme/047 | 30 +++++++++++-----------
tests/nvme/048 | 46 +++++++++++++++------------------
tests/nvme/049 | 1 +
tests/nvme/rc | 30 +++++++++++++++++++---
47 files changed, 572 insertions(+), 585 deletions(-)
--
2.41.0
next reply other threads:[~2023-07-26 12:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 12:46 Daniel Wagner [this message]
2023-07-26 12:46 ` [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations Daniel Wagner
2023-07-26 14:54 ` Bart Van Assche
2023-07-27 7:11 ` Daniel Wagner
2023-07-27 15:18 ` Bart Van Assche
2023-07-28 5:06 ` Shinichiro Kawasaki
2023-07-28 6:46 ` Daniel Wagner
2023-07-28 7:58 ` Shinichiro Kawasaki
2023-07-26 12:46 ` [PATCH blktests v1 02/11] nvme: Reorganize test preamble code section Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 03/11] nvme/rc: Add common subsystem nqn define Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 04/11] nvme: Use def_subsysnqn variable instead local variable Daniel Wagner
2023-07-28 8:04 ` Shinichiro Kawasaki
2023-07-26 12:46 ` [PATCH blktests v1 05/11] nvme/{041,042,043,044,045,048}: Remove local variable hostnqn and hostid Daniel Wagner
2023-07-28 8:10 ` Shinichiro Kawasaki
2023-07-28 8:52 ` Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 06/11] nvme/rc: Add common file_path name define Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 07/11] nvme: Use def_file_path variable instead local variable Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 08/11] nvme/rc: Add common def_subsys_uuid define Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 09/11] nvme: Use def_subsys_uuid variable Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 10/11] nvme/rc: Add helper for adding/removing to allow list Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 11/11] nvme: Add explicitly host to allow_host list Daniel Wagner
2023-07-28 8:15 ` Shinichiro Kawasaki
2023-07-28 8:55 ` Daniel Wagner
2023-07-28 8:20 ` [PATCH blktests v1 00/11] Switch to allowed_host Shinichiro Kawasaki
2023-07-28 8:59 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726124644.12619-1-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=hare@suse.de \
--cc=jsmart2021@gmail.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®