From: Jann Horn <jannh@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linuxfoundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Suren Baghdasaryan <surenb@google.com>,
Matthew Wilcox <willy@infradead.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Alan Stern <stern@rowland.harvard.edu>,
Andrea Parri <parri.andrea@gmail.com>,
Will Deacon <will@kernel.org>, Boqun Feng <boqun.feng@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
David Howells <dhowells@redhat.com>,
Jade Alglave <j.alglave@ucl.ac.uk>,
Luc Maranget <luc.maranget@inria.fr>,
"Paul E. McKenney" <paulmck@kernel.org>,
Akira Yokosawa <akiyks@gmail.com>,
Daniel Lustig <dlustig@nvidia.com>,
Joel Fernandes <joel@joelfernandes.org>
Subject: [PATCH 0/2] fix vma->anon_vma check for per-VMA locking; fix anon_vma memory ordering
Date: Wed, 26 Jul 2023 23:41:01 +0200 [thread overview]
Message-ID: <20230726214103.3261108-1-jannh@google.com> (raw)
Hi!
Patch 1 here is a straightforward fix for a race in per-VMA locking code
that can lead to use-after-free; I hope we can get this one into
mainline and stable quickly.
Patch 2 is a fix for what I believe is a longstanding memory ordering
issue in how vma->anon_vma is used across the MM subsystem; I expect
that this one will have to go through a few iterations of review and
potentially rewrites, because memory ordering is tricky.
(If someone else wants to take over patch 2, I would be very happy.)
These patches don't really belong together all that much, I'm just
sending them as a series because they'd otherwise conflict.
I am CCing:
- Suren because patch 1 touches his code
- Matthew Wilcox because he is also currently working on per-VMA
locking stuff
- all the maintainers/reviewers for the Kernel Memory Consistency Model
so they can help figure out the READ_ONCE() vs smp_load_acquire()
thing
- people involved in the previous discussion on the security list
Jann Horn (2):
mm: lock_vma_under_rcu() must check vma->anon_vma under vma lock
mm: Fix anon_vma memory ordering
include/linux/rmap.h | 15 ++++++++++++++-
mm/huge_memory.c | 4 +++-
mm/khugepaged.c | 2 +-
mm/ksm.c | 16 +++++++++++-----
mm/memory.c | 32 ++++++++++++++++++++------------
mm/mmap.c | 13 ++++++++++---
mm/rmap.c | 6 ++++--
mm/swapfile.c | 3 ++-
8 files changed, 65 insertions(+), 26 deletions(-)
base-commit: 20ea1e7d13c1b544fe67c4a8dc3943bb1ab33e6f
--
2.41.0.487.g6d72f3e995-goog
next reply other threads:[~2023-07-26 21:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 21:41 Jann Horn [this message]
2023-07-26 21:41 ` [PATCH 1/2] mm: lock_vma_under_rcu() must check vma->anon_vma under vma lock Jann Horn
2023-07-27 21:52 ` Suren Baghdasaryan
2023-07-26 21:41 ` [PATCH 2/2] mm: Fix anon_vma memory ordering Jann Horn
2023-07-26 21:50 ` Jann Horn
2023-07-27 18:25 ` Linus Torvalds
2023-07-26 23:19 ` [PATCH 0/2] fix vma->anon_vma check for per-VMA locking; fix " Paul E. McKenney
2023-07-27 14:39 ` Jann Horn
2023-07-27 14:57 ` Will Deacon
2023-07-27 15:44 ` Alan Stern
2023-07-27 16:10 ` Jann Horn
2023-07-27 16:17 ` Paul E. McKenney
2023-07-27 16:16 ` Paul E. McKenney
2023-07-27 17:11 ` Linus Torvalds
2023-07-27 17:41 ` Alan Stern
2023-07-27 18:01 ` Linus Torvalds
2023-07-27 19:05 ` Nadav Amit
2023-07-27 19:39 ` Linus Torvalds
2023-07-27 20:11 ` Nadav Amit
2023-07-28 9:18 ` Nadav Amit
2023-07-27 15:07 ` Matthew Wilcox
2023-07-27 15:15 ` Jann Horn
2023-07-27 16:09 ` Paul E. McKenney
2023-07-27 16:34 Joel Fernandes
2023-07-28 12:44 ` Will Deacon
2023-07-28 17:35 ` Joel Fernandes
2023-07-28 17:51 ` Alan Stern
2023-07-28 18:03 ` Joel Fernandes
2023-07-28 18:18 ` Paul E. McKenney
2023-07-28 19:50 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726214103.3261108-1-jannh@google.com \
--to=jannh@google.com \
--cc=akiyks@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=surenb@google.com \
--cc=torvalds@linuxfoundation.org \
--cc=will@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®