From: Sohil Mehta <sohil.mehta@intel.com>
To: x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Tony Luck <tony.luck@intel.com>,
Sohil Mehta <sohil.mehta@intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/3] x86/smpboot: Remove a stray comment about CPU hotplug
Date: Thu, 27 Jul 2023 18:05:31 +0000 [thread overview]
Message-ID: <20230727180533.3119660-2-sohil.mehta@intel.com> (raw)
In-Reply-To: <20230727180533.3119660-1-sohil.mehta@intel.com>
This old comment is irrelavant to the logic of disabling interrupts and
could be misleading. Remove it.
Now, hlt_play_dead() resembles the code that the comment was initially
added for, but, it doesn't make sense anymore because an offlined cpu
could also be put into other states such as mwait.
Signed-off-by: Sohil Mehta <sohil.mehta@intel.com>
---
arch/x86/kernel/smpboot.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index e1aa2cd7734b..6a09a021b534 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1614,9 +1614,7 @@ void play_dead_common(void)
idle_task_exit();
cpuhp_ap_report_dead();
- /*
- * With physical CPU hotplug, we should halt the cpu
- */
+
local_irq_disable();
}
--
2.34.1
next prev parent reply other threads:[~2023-07-27 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 18:05 [PATCH v2 0/3] x86/smpboot: Minor cleanup Sohil Mehta
2023-07-27 18:05 ` Sohil Mehta [this message]
2023-07-28 8:21 ` [tip: x86/core] x86/smpboot: Remove a stray comment about CPU hotplug tip-bot2 for Sohil Mehta
2023-07-27 18:05 ` [PATCH v2 2/3] x86/smp: Remove a non-existent function declaration Sohil Mehta
2023-07-28 8:21 ` [tip: x86/core] " tip-bot2 for Sohil Mehta
2023-07-27 18:05 ` [PATCH v2 3/3] x86/smpboot: Change smp_store_boot_cpu_info() to static Sohil Mehta
2023-07-28 8:21 ` [tip: x86/core] " tip-bot2 for Sohil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727180533.3119660-2-sohil.mehta@intel.com \
--to=sohil.mehta@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®