From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7E76C001DC for ; Fri, 28 Jul 2023 00:29:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232353AbjG1A3U (ORCPT ); Thu, 27 Jul 2023 20:29:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230230AbjG1A3S (ORCPT ); Thu, 27 Jul 2023 20:29:18 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 198DC271C; Thu, 27 Jul 2023 17:29:16 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CF0A0D75; Thu, 27 Jul 2023 17:29:58 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1BEB33F5A1; Thu, 27 Jul 2023 17:29:13 -0700 (PDT) Date: Fri, 28 Jul 2023 01:28:24 +0100 From: Andre Przywara To: Matthew Croughan Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] dt-bindings: arm: sunxi: add Mango Pi MQ-Quad binding Message-ID: <20230728012818.52f32a00@slackpad.lan> In-Reply-To: <20230719172551.3248166-3-matthew.croughan@nix.how> References: <20230719172551.3248166-1-matthew.croughan@nix.how> <20230719172551.3248166-3-matthew.croughan@nix.how> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.1 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Jul 2023 18:25:40 +0100 Matthew Croughan wrote: > Document board compatible names for Mango Pi MQ-Quad > > Signed-off-by: Matthew Croughan Thanks, this looks alright, but needs to be the first patch in this series. Otherwise dt-validate would fail when bisecting lands just in the middle. For the patch itself: Reviewed-by: Andre Przywara Cheers, Andre > --- > Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > index ee8fdd2da869..2dee815fd45e 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > @@ -862,6 +862,11 @@ properties: > - const: wexler,tab7200 > - const: allwinner,sun7i-a20 > > + - description: MangoPi MQ-Quad > + items: > + - const: widora,mangopi-mq-quad > + - const: allwinner,sun50i-h616 > + > - description: MangoPi MQ-R board > items: > - const: widora,mangopi-mq-r-t113