From: like@awinic.com
To: broonie@kernel.org
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com,
liangdong@awinic.com, like@awinic.com,
linux-kernel@vger.kernel.org, liweilei@awinic.com,
robh+dt@kernel.org, wangweidong.a@awinic.com
Subject: Re: [PATCH V1 1/2] regulator: aw37503: add regulator driver for AWINIC AW37503
Date: Fri, 28 Jul 2023 03:20:04 +0000 [thread overview]
Message-ID: <20230728032004.1479251-1-like@awinic.com> (raw)
In-Reply-To: <812a3f8b-7d5d-42f2-aaf2-dcea18f6ffac@sirena.org.uk>
Hello Mark Brown,
Thank you very much for your advice.
> On Wed, Jul 26, 2023 at 08:16:11AM +0000, like@awinic.com wrote:
>
> > @@ -191,5 +191,6 @@ obj-$(CONFIG_REGULATOR_WM831X) += wm831x-ldo.o
> > obj-$(CONFIG_REGULATOR_WM8350) += wm8350-regulator.o
> > obj-$(CONFIG_REGULATOR_WM8400) += wm8400-regulator.o
> > obj-$(CONFIG_REGULATOR_WM8994) += wm8994-regulator.o
> > +obj-$(CONFIG_REGULATOR_AW37503) += aw37503-regulator.o
> >
>
> Please keep the Kconfig and Makefile sorted.
I will modify the sorting of AW37503 as suggested.
> > +static const struct regmap_config aw37503_regmap_config = {
> > + .reg_bits = 8,
> > + .val_bits = 8,
> > + .max_register = AW37503_REG_WPRTEN,
> > + .cache_type = REGCACHE_NONE,
>
> No need to specify no cache, it's the default.
I will modify it as suggested.
Best regards,
Alec Li
next prev parent reply other threads:[~2023-07-28 3:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 8:16 [PATCH V1 0/2] " like
2023-07-26 8:16 ` [PATCH V1 1/2] " like
2023-07-26 11:16 ` Krzysztof Kozlowski
2023-07-28 3:19 ` like
2023-07-26 11:41 ` Mark Brown
2023-07-28 3:20 ` like [this message]
2023-07-26 20:13 ` Christophe JAILLET
2023-07-28 3:20 ` like
2023-07-26 8:16 ` [PATCH V1 2/2] regulator: aw37503: add device-tree binding like
2023-07-26 10:52 ` Rob Herring
2023-07-28 3:18 ` like
2023-07-26 11:15 ` Krzysztof Kozlowski
2023-07-28 3:19 ` like
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728032004.1479251-1-like@awinic.com \
--to=like@awinic.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=liangdong@awinic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liweilei@awinic.com \
--cc=robh+dt@kernel.org \
--cc=wangweidong.a@awinic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®