From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21315C04A6A for ; Sat, 29 Jul 2023 08:47:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231408AbjG2IrH (ORCPT ); Sat, 29 Jul 2023 04:47:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjG2IrF (ORCPT ); Sat, 29 Jul 2023 04:47:05 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B7BF130; Sat, 29 Jul 2023 01:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=hZxS+x+pcA2ToPDaUJGjYOohekYFrjewNaNVS7Ilstc=; b=COUwAi2vBLkFax60GDJ079xgm7 l9atmYYOgcbl+kn4l8Iy5pde/3yCNOX1xwYwYPppKrWajErYPJWWPcSjrRz2Xg0pq3NFeABGUkVqj QSiC+NDeBcYciIqfXb/n70jnsE/R8tWpmeG71q6XzVlZoqdLD4+bpa2BAAlWs9fbypot/+rfR5aPZ LilTjokhsJmLovenFArcFVt2SRIgliUdgSu91064hDqzzK5lr1rpvDWib+barevsAjmYcte6J0krP RTEuuetlKQnoeoeeVwNUQ/nXyV5M3xAhCkBklEZinOfDcbBDwtW0IVGDIIUWbKZYtnD+/3YE+pqTy 8f3xefvQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qPfb2-009uZE-Cq; Sat, 29 Jul 2023 08:46:45 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 6FFF93002CE; Sat, 29 Jul 2023 10:46:44 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 588B3202C39FE; Sat, 29 Jul 2023 10:46:44 +0200 (CEST) Date: Sat, 29 Jul 2023 10:46:44 +0200 From: Peter Zijlstra To: "Rafael J. Wysocki" Cc: anna-maria@linutronix.de, tglx@linutronix.de, frederic@kernel.org, gautham.shenoy@amd.com, linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, linux-pm@vger.kernel.org, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com Subject: Re: [RFC][PATCH 3/3] cpuidle,teo: Improve state selection Message-ID: <20230729084644.GC3945851@hirez.programming.kicks-ass.net> References: <20230728145515.990749537@infradead.org> <20230728145808.970594909@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 28, 2023 at 07:07:02PM +0200, Rafael J. Wysocki wrote: > On Fri, Jul 28, 2023 at 5:01 PM Peter Zijlstra wrote: > > > > When selecting a state, stop when history tells us 66% of recent idles > > were at or below our current state. > > This is not really about "recent idles" AFAICS. It stops the > selection when 66% of the total sum of the "hits" and "intercepts" > signals comes from the current state and the states below it. This > covers the entire history, while the "recent" ones are counted > separately. Ah, bad wording perhaps. I found that 'recent' list teo has very hard to use, also the regular state isn't that long lived as per the reply on the previous patch.