From: Ira Weiny <ira.weiny@intel.com>
To: Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
Ira Weiny <ira.weiny@intel.com>
Subject: [PATCH v2 2/2] cxl/mbox: Add handle to event processing debug
Date: Tue, 01 Aug 2023 13:13:29 -0700 [thread overview]
Message-ID: <20230731-cxl-fix-clear-event-debug-print-v2-2-9bdd08d386e9@intel.com> (raw)
In-Reply-To: <20230731-cxl-fix-clear-event-debug-print-v2-0-9bdd08d386e9@intel.com>
Knowing which handle is being processed helped in debugging new event
code. Add a dev_dbg() message with this information.
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
drivers/cxl/core/mbox.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
index a1c490f66bbf..f052d5f174ee 100644
--- a/drivers/cxl/core/mbox.c
+++ b/drivers/cxl/core/mbox.c
@@ -947,9 +947,13 @@ static void cxl_mem_get_records_log(struct cxl_memdev_state *mds,
if (!nr_rec)
break;
- for (i = 0; i < nr_rec; i++)
+ for (i = 0; i < nr_rec; i++) {
+ dev_dbg(dev, "Event log %d: processing handle %u\n",
+ type,
+ le16_to_cpu(payload->records[i].hdr.handle));
cxl_event_trace_record(cxlmd, type,
&payload->records[i]);
+ }
if (payload->flags & CXL_GET_EVENT_FLAG_OVERFLOW)
trace_cxl_overflow(cxlmd, type, payload);
--
2.41.0
next prev parent reply other threads:[~2023-08-01 20:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 20:13 [PATCH v2 0/2] CXL/events: Fix and improve event dev_dbg() messages Ira Weiny
2023-08-01 20:13 ` [PATCH v2 1/2] cxl/mbox: Use correct handle in events debug message Ira Weiny
2023-08-01 20:41 ` Dave Jiang
2023-08-02 16:26 ` Alison Schofield
2023-08-04 12:16 ` Jonathan Cameron
2023-08-01 20:13 ` Ira Weiny [this message]
2023-08-01 20:41 ` [PATCH v2 2/2] cxl/mbox: Add handle to event processing debug Dave Jiang
2023-08-02 16:29 ` Alison Schofield
2023-08-03 5:05 ` Ira Weiny
2023-08-03 17:26 ` Alison Schofield
2023-08-04 12:17 ` Jonathan Cameron
2023-08-03 17:26 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731-cxl-fix-clear-event-debug-print-v2-2-9bdd08d386e9@intel.com \
--to=ira.weiny@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®