mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jinyoung Choi <j-young.choi@samsung.com>
To: "hch@lst.de" <hch@lst.de>
Cc: "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"kbusch@kernel.org" <kbusch@kernel.org>,
	"chaitanya.kulkarni@wdc.com" <chaitanya.kulkarni@wdc.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE:(2) [PATCH 2/2] bio-integrity: create multi-page bvecs in bio_integrity_add_page()
Date: Mon, 31 Jul 2023 15:35:07 +0900	[thread overview]
Message-ID: <20230731063507epcms2p185efd3a1774bf0482cd7133a509863d6@epcms2p1> (raw)
In-Reply-To: <20230731055524.GA30066@lst.de>

> On Fri, Jul 28, 2023 at 04:57:53PM +0900, Jinyoung Choi wrote:
> > Allow bio_integrity_add_page to create multi-page bvecs, just like
> > the bio payloads. This simplifies adding larger payloads, and fixes
> > support for non-tiny workloads with nvme, which stopped using
> > scatterlist for metadata a while ago
> 
> Missing dot at the end of the sentence here.  Also the commit log feels
> very short to me for such a substanial change, although even thinking
> hard about it I'm not entirely sure what would be missing, so it's
> probably fine..
> 
> Looks good to me:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Hi, Christoph.

I will add a commit message for the substanial change.

Oh, and I missed some patches that should be included in the patch set.
In the next version, I will add patches that are affected by this patch 
and must be changed.

Thank you for your review.

Best Regards,
Jinyoung.

      parent reply	other threads:[~2023-07-31  6:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230728075537epcms2p194154023a4cdbe37c0346ef1102d1d63@epcms2p1>
2023-07-28  7:55 ` [PATCH 0/2] multi-page bvec configuration for integrity payload Jinyoung Choi
     [not found]   ` <CGME20230728075537epcms2p194154023a4cdbe37c0346ef1102d1d63@epcms2p7>
2023-07-28  7:57     ` [PATCH 2/2] bio-integrity: create multi-page bvecs in bio_integrity_add_page() Jinyoung Choi
2023-07-31  5:55       ` hch
2023-07-28  7:57 ` [PATCH 1/2] block: make bvec_try_merge_hw_page() non-static Jinyoung Choi
2023-07-31  5:55   ` hch
2023-07-31  6:35 ` Jinyoung Choi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230731063507epcms2p185efd3a1774bf0482cd7133a509863d6@epcms2p1 \
    --to=j-young.choi@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®