From: Jorge Lopez <jorgealtxwork@gmail.com>
To: hdegoede@redhat.com, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas@t-8ch.de,
ilpo.jarvinen@linux.intel.com, dan.carpenter@linaro.org
Subject: [PATCH 8/8] hp-bioscfg: Remove duplicate use of variable in inner loop
Date: Mon, 31 Jul 2023 15:31:41 -0500 [thread overview]
Message-ID: <20230731203141.30044-9-jorge.lopez2@hp.com> (raw)
In-Reply-To: <20230731203141.30044-1-jorge.lopez2@hp.com>
Replace use of same variable in inner loop.
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com>
---
Based on the latest platform-drivers-x86.git/for-next
---
.../x86/hp/hp-bioscfg/order-list-attributes.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c
index 3b073910b430..cffc1c9ba3e7 100644
--- a/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c
+++ b/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c
@@ -136,6 +136,7 @@ static int hp_populate_ordered_list_elements_from_package(union acpi_object *ord
u32 size;
u32 int_value = 0;
int elem;
+ int olist_elem;
int reqs;
int eloc;
char *tmpstr = NULL;
@@ -147,10 +148,7 @@ static int hp_populate_ordered_list_elements_from_package(union acpi_object *ord
if (!order_obj)
return -EINVAL;
- for (elem = 1, eloc = 1; elem < order_obj_count; elem++, eloc++) {
- /* ONLY look at the first ORDERED_ELEM_CNT elements */
- if (eloc == ORD_ELEM_CNT)
- goto exit_list;
+ for (elem = 1, eloc = 1; eloc < ORD_ELEM_CNT; elem++, eloc++) {
switch (order_obj[elem].type) {
case ACPI_TYPE_STRING:
@@ -277,10 +275,10 @@ static int hp_populate_ordered_list_elements_from_package(union acpi_object *ord
tmpstr,
sizeof(ordered_list_data->elements[0]));
- for (elem = 1; elem < MAX_ELEMENTS_SIZE && part; elem++) {
- strscpy(ordered_list_data->elements[elem],
+ for (olist_elem = 1; olist_elem < MAX_ELEMENTS_SIZE && part; olist_elem++) {
+ strscpy(ordered_list_data->elements[olist_elem],
part,
- sizeof(ordered_list_data->elements[elem]));
+ sizeof(ordered_list_data->elements[olist_elem]));
part = strsep(&part_tmp, SEMICOLON_SEP);
}
--
2.34.1
next prev parent reply other threads:[~2023-07-31 20:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 20:31 [PATCH 0/8] hp-bioscfg: Overall fixes and code cleanup Jorge Lopez
2023-07-31 20:31 ` [PATCH 1/8] hp-bioscfg: Fix memory leaks in attribute packages Jorge Lopez
2023-07-31 20:31 ` [PATCH 2/8] hp-bioscfg: Fix uninitialized variable errors Jorge Lopez
2023-07-31 20:31 ` [PATCH 3/8] hp-bioscfg: Replace the word HACK from source code Jorge Lopez
2023-07-31 20:31 ` [PATCH 4/8] hp-bioscfg: Change how prerequisites size is evaluated Jorge Lopez
2023-07-31 20:31 ` [PATCH 5/8] hp-bioscfg: Change how order list " Jorge Lopez
2023-07-31 20:31 ` [PATCH 6/8] hp-bioscfg: Change how enum possible values " Jorge Lopez
2023-07-31 20:31 ` [PATCH 7/8] hp-bioscfg: Change how password encoding " Jorge Lopez
2023-07-31 20:31 ` Jorge Lopez [this message]
2023-08-01 13:35 ` [PATCH 0/8] hp-bioscfg: Overall fixes and code cleanup Dan Carpenter
2023-08-01 14:52 ` Jorge Lopez
2023-08-01 15:04 ` Dan Carpenter
2023-08-01 15:10 ` Jorge Lopez
2023-08-01 15:36 ` Dan Carpenter
2023-08-07 11:38 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731203141.30044-9-jorge.lopez2@hp.com \
--to=jorgealtxwork@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=thomas@t-8ch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®