mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: linux-erofs@lists.ozlabs.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Christian Brauner <brauner@kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	linux-fsdevel@vger.kernel.org,
	Gao Xiang <hsiangkao@linux.alibaba.com>
Subject: [PATCH] erofs: drop unnecessary WARN_ON() in erofs_kill_sb()
Date: Tue,  1 Aug 2023 09:47:37 +0800	[thread overview]
Message-ID: <20230801014737.28614-1-hsiangkao@linux.alibaba.com> (raw)
In-Reply-To: <20230731-flugbereit-wohnlage-78acdf95ab7e@brauner>

Previously, .kill_sb() will be called only after fill_super fails.
It will be changed [1].

Besides, checking for s_magic in erofs_kill_sb() is unnecessary from
any point of view.  Let's get rid of it now.

[1] https://lore.kernel.org/r/20230731-flugbereit-wohnlage-78acdf95ab7e@brauner
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
will upstream this commit later this week after it lands -next.

 fs/erofs/super.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 9d6a3c6158bd..566f68ddfa36 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -889,8 +889,6 @@ static void erofs_kill_sb(struct super_block *sb)
 {
 	struct erofs_sb_info *sbi;
 
-	WARN_ON(sb->s_magic != EROFS_SUPER_MAGIC);
-
 	/* pseudo mount for anon inodes */
 	if (sb->s_flags & SB_KERNMOUNT) {
 		kill_anon_super(sb);
-- 
2.24.4


  reply	other threads:[~2023-08-01  1:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31  7:57 [syzbot] [erofs?] [fat?] WARNING in erofs_kill_sb syzbot
2023-07-31  9:37 ` Christoph Hellwig
2023-07-31 10:58   ` Gao Xiang
2023-07-31 11:16     ` Christoph Hellwig
2023-07-31 12:43       ` Christian Brauner
2023-07-31 13:22         ` Christian Brauner
2023-07-31 13:53           ` Christoph Hellwig
2023-07-31 13:57             ` Christian Brauner
2023-07-31 16:32               ` Christian Brauner
2023-08-01  1:47                 ` Gao Xiang [this message]
2023-08-01  7:19                   ` [PATCH] erofs: drop unnecessary WARN_ON() in erofs_kill_sb() Christian Brauner
2023-08-01  7:51                   ` Christoph Hellwig
2023-07-31 13:29         ` [syzbot] [erofs?] [fat?] WARNING in erofs_kill_sb Gao Xiang
2023-08-29  3:40 ` Gao Xiang
2023-08-29  4:14   ` [syzbot] [erofs?] " syzbot
2023-08-29  5:32     ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230801014737.28614-1-hsiangkao@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=brauner@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®