From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB6CC0015E for ; Tue, 1 Aug 2023 14:00:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232366AbjHAOAi (ORCPT ); Tue, 1 Aug 2023 10:00:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230305AbjHAOAg (ORCPT ); Tue, 1 Aug 2023 10:00:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91D75C3 for ; Tue, 1 Aug 2023 07:00:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 30733615BA for ; Tue, 1 Aug 2023 14:00:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D672C433C8; Tue, 1 Aug 2023 14:00:32 +0000 (UTC) Date: Tue, 1 Aug 2023 10:00:30 -0400 From: Steven Rostedt To: Yajun Deng Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched/rt: move back to RT_GROUP_SCHED and rename it child Message-ID: <20230801100030.5efec7e2@gandalf.local.home> In-Reply-To: <20230801062714.3424299-1-yajun.deng@linux.dev> References: <20230801062714.3424299-1-yajun.deng@linux.dev> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Aug 2023 14:27:14 +0800 Yajun Deng wrote: > @@ -228,13 +228,10 @@ void init_tg_rt_entry(struct task_group *tg, struct rt_rq *rt_rq, > if (!rt_se) > return; > > - if (!parent) > - rt_se->rt_rq = &rq->rt; > - else > - rt_se->rt_rq = parent->my_q; > - > + rt_se->rt_rq = parent->my_q; So when this is called with parent = NULL, this will crash? -- Steve > rt_se->my_q = rt_rq; > rt_se->parent = parent; > + parent->child = rt_se; > INIT_LIST_HEAD(&rt_se->run_list); > } >