From: Cyril Hrubis <chrubis@suse.cz>
To: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
linux-kernel@vger.kernel.org
Cc: ltp@lists.linux.it, Cyril Hrubis <chrubis@suse.cz>,
Jiri Bohac <jbohac@suse.cz>, Petr Vorel <pvorel@suse.cz>
Subject: [PATCH 2/2 RESEND] sched/rt: sysctl_sched_rr_timeslice show default timeslice after reset
Date: Wed, 2 Aug 2023 17:19:06 +0200 [thread overview]
Message-ID: <20230802151906.25258-3-chrubis@suse.cz> (raw)
In-Reply-To: <20230802151906.25258-1-chrubis@suse.cz>
The sched_rr_timeslice can be reset to default by writing value that is
<= 0. However after reading from this file we always got the last value
written, which is not useful at all.
$ echo -1 > /proc/sys/kernel/sched_rr_timeslice_ms
$ cat /proc/sys/kernel/sched_rr_timeslice_ms
-1
Fix this by setting the variable that holds the sysctl file value to the
jiffies_to_msecs(RR_TIMESLICE) in case that <= 0 value was written.
CC: Jiri Bohac <jbohac@suse.cz>
Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
Acked-by: Mel Gorman <mgorman@suse.de>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Tested-by: Petr Vorel <pvorel@suse.cz>
---
kernel/sched/rt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 185d3d749f6b..0597ba0f85ff 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -3062,6 +3062,9 @@ static int sched_rr_handler(struct ctl_table *table, int write, void *buffer,
sched_rr_timeslice =
sysctl_sched_rr_timeslice <= 0 ? RR_TIMESLICE :
msecs_to_jiffies(sysctl_sched_rr_timeslice);
+
+ if (sysctl_sched_rr_timeslice <= 0)
+ sysctl_sched_rr_timeslice = jiffies_to_msecs(RR_TIMESLICE);
}
mutex_unlock(&mutex);
--
2.41.0
next prev parent reply other threads:[~2023-08-02 15:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 15:19 [PATCH 0/2 RESEND] Two fixes for sysctl_sched_rr_timeslice Cyril Hrubis
2023-08-02 15:19 ` [PATCH 1/2 RESEND] sched/rt: Fix sysctl_sched_rr_timeslice intial value Cyril Hrubis
2023-08-14 15:08 ` [tip: sched/core] " tip-bot2 for Cyril Hrubis
2023-08-02 15:19 ` Cyril Hrubis [this message]
2023-08-14 15:08 ` [tip: sched/core] sched/rt: sysctl_sched_rr_timeslice show default timeslice after reset tip-bot2 for Cyril Hrubis
2023-08-10 8:30 ` [PATCH 0/2 RESEND] Two fixes for sysctl_sched_rr_timeslice Mel Gorman
2023-08-10 10:26 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802151906.25258-3-chrubis@suse.cz \
--to=chrubis@suse.cz \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jbohac@suse.cz \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pvorel@suse.cz \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®