From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DCD5C001DF for ; Wed, 2 Aug 2023 18:56:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232799AbjHBS4Y (ORCPT ); Wed, 2 Aug 2023 14:56:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231361AbjHBS4I (ORCPT ); Wed, 2 Aug 2023 14:56:08 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B842CED for ; Wed, 2 Aug 2023 11:55:43 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B311F9CA; Wed, 2 Aug 2023 20:54:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1691002478; bh=94D6ozUfI9FATQhs8jDdOIKGUnPXh85AgH0XdSn+Ugo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U1JGjkj0h265uJOSh/awUPBTfJYjqi8tAgeC2oGwyaqDZuZM+2EyfRzbBXYYXft+9 sQNzPbqGc3i2X+hRLJR0KVUPF+E2dFDcbUaF1wbyHQoPwawrVLk2m80l76o+rZrwiN WdmcrS4nxYFU8PGkf63zbl4Rt625+jXpnBOBGh+E= Date: Wed, 2 Aug 2023 21:55:47 +0300 From: Laurent Pinchart To: Dmitry Baryshkov Cc: David Airlie , Daniel Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Andy Gross , Bjorn Andersson , Konrad Dybcio , Simon Ser , Janne Grunau , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , "Pan, Xinhui" , Harry Wentland , Leo Li , Rodrigo Siqueira , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/4] drm/uapi: document the USB subconnector type Message-ID: <20230802185547.GC32500@pendragon.ideasonboard.com> References: <20230729004913.215872-1-dmitry.baryshkov@linaro.org> <20230729004913.215872-4-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230729004913.215872-4-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, Thank you for the patch. On Sat, Jul 29, 2023 at 03:49:12AM +0300, Dmitry Baryshkov wrote: > To properly define the USB-C DP altmode connectors, add the USB > subconnector type. > > Suggested-by: Simon Ser > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/drm_connector.c | 1 + > include/uapi/drm/drm_mode.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index a6066e4a5e9a..9e96b038f5d0 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -1050,6 +1050,7 @@ static const struct drm_prop_enum_list drm_dp_subconnector_enum_list[] = { > { DRM_MODE_SUBCONNECTOR_DisplayPort, "DP" }, /* DP */ > { DRM_MODE_SUBCONNECTOR_Wireless, "Wireless" }, /* DP */ > { DRM_MODE_SUBCONNECTOR_Native, "Native" }, /* DP */ > + { DRM_MODE_SUBCONNECTOR_USB, "USB" }, /* DP */ Should this be DRM_MODE_SUBCONNECTOR_USB_C and "USB-C", in case we get another USB type later ? > }; > > DRM_ENUM_NAME_FN(drm_get_dp_subconnector_name, > diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h > index 92d96a2b6763..0f74918b011c 100644 > --- a/include/uapi/drm/drm_mode.h > +++ b/include/uapi/drm/drm_mode.h > @@ -398,6 +398,7 @@ enum drm_mode_subconnector { > DRM_MODE_SUBCONNECTOR_HDMIA = 11, /* DP */ > DRM_MODE_SUBCONNECTOR_Native = 15, /* DP */ > DRM_MODE_SUBCONNECTOR_Wireless = 18, /* DP */ > + DRM_MODE_SUBCONNECTOR_USB = 20, /* DP */ > }; > > #define DRM_MODE_CONNECTOR_Unknown 0 -- Regards, Laurent Pinchart