From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C34E5C001DF for ; Wed, 2 Aug 2023 19:13:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230228AbjHBTNw (ORCPT ); Wed, 2 Aug 2023 15:13:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229598AbjHBTNs (ORCPT ); Wed, 2 Aug 2023 15:13:48 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBF96EC for ; Wed, 2 Aug 2023 12:13:47 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B020529A; Wed, 2 Aug 2023 21:12:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1691003562; bh=CVkqiGN6D6UgmkqJhxQvXwEJAm+V2yj4Zy5N7hQh5Tg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RLWNuwBSmT8O4GPjcjV6r2fo3i09KG+4xa5jcqvTmPP0lxfQLNPNizMo7A2EhQr7O ag/0JGGVvJT5DXb8Wfv8vn0bnxrkOLC3Me/FHSqN9je4M6V97qIvve0PbK4K78IXNf srsnWIJ68770hFveG9VAnPJe6TQWekzeCaFh5gss= Date: Wed, 2 Aug 2023 22:13:51 +0300 From: Laurent Pinchart To: Dmitry Baryshkov Cc: David Airlie , Daniel Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Andy Gross , Bjorn Andersson , Konrad Dybcio , Simon Ser , Janne Grunau , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , "Pan, Xinhui" , Harry Wentland , Leo Li , Rodrigo Siqueira , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/4] drm/uapi: document the USB subconnector type Message-ID: <20230802191351.GA1407@pendragon.ideasonboard.com> References: <20230729004913.215872-1-dmitry.baryshkov@linaro.org> <20230729004913.215872-4-dmitry.baryshkov@linaro.org> <20230802185547.GC32500@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 02, 2023 at 10:01:19PM +0300, Dmitry Baryshkov wrote: > On 02/08/2023 21:55, Laurent Pinchart wrote: > > Hi Dmitry, > > > > Thank you for the patch. > > > > On Sat, Jul 29, 2023 at 03:49:12AM +0300, Dmitry Baryshkov wrote: > >> To properly define the USB-C DP altmode connectors, add the USB > >> subconnector type. > >> > >> Suggested-by: Simon Ser > >> Signed-off-by: Dmitry Baryshkov > >> --- > >> drivers/gpu/drm/drm_connector.c | 1 + > >> include/uapi/drm/drm_mode.h | 1 + > >> 2 files changed, 2 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > >> index a6066e4a5e9a..9e96b038f5d0 100644 > >> --- a/drivers/gpu/drm/drm_connector.c > >> +++ b/drivers/gpu/drm/drm_connector.c > >> @@ -1050,6 +1050,7 @@ static const struct drm_prop_enum_list drm_dp_subconnector_enum_list[] = { > >> { DRM_MODE_SUBCONNECTOR_DisplayPort, "DP" }, /* DP */ > >> { DRM_MODE_SUBCONNECTOR_Wireless, "Wireless" }, /* DP */ > >> { DRM_MODE_SUBCONNECTOR_Native, "Native" }, /* DP */ > >> + { DRM_MODE_SUBCONNECTOR_USB, "USB" }, /* DP */ > > > > Should this be DRM_MODE_SUBCONNECTOR_USB_C and "USB-C", in case we get > > another USB type later ? > > Hmm, which id should I use for micro-USB then? (consider anx7808, > SlimPort). I thought about using DRM_MODE_SUBCONNECTOR_USB for both of > them. But maybe I should add another subtype for SlimPort. I suppose it depends on whether userspace needs a way to differentiate those. Do you have a good visibility on the userspace use cases ? > >> }; > >> > >> DRM_ENUM_NAME_FN(drm_get_dp_subconnector_name, > >> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h > >> index 92d96a2b6763..0f74918b011c 100644 > >> --- a/include/uapi/drm/drm_mode.h > >> +++ b/include/uapi/drm/drm_mode.h > >> @@ -398,6 +398,7 @@ enum drm_mode_subconnector { > >> DRM_MODE_SUBCONNECTOR_HDMIA = 11, /* DP */ > >> DRM_MODE_SUBCONNECTOR_Native = 15, /* DP */ > >> DRM_MODE_SUBCONNECTOR_Wireless = 18, /* DP */ > >> + DRM_MODE_SUBCONNECTOR_USB = 20, /* DP */ > >> }; > >> > >> #define DRM_MODE_CONNECTOR_Unknown 0 -- Regards, Laurent Pinchart