mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Andrew Davis <afd@ti.com>
Subject: [PATCH 03/13] arm64: dts: ti: k3-j721s2: Enable SDHCI nodes at the board level
Date: Wed, 2 Aug 2023 15:52:59 -0500	[thread overview]
Message-ID: <20230802205309.257392-4-afd@ti.com> (raw)
In-Reply-To: <20230802205309.257392-1-afd@ti.com>

SDHCI nodes defined in the top-level J721s2 SoC dtsi files are incomplete
and will not be functional unless they are extended.

As the attached SD/eMMC is only known about at the board integration level,
these nodes should only be enabled when provided with this information.

Disable the SDHCI nodes in the dtsi files and only enable the ones that
are actually pinned out on a given board.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts       | 6 +-----
 arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts | 2 ++
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi             | 2 ++
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
index 21ad49cfa7eed..ffca12df0a6da 100644
--- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
@@ -373,13 +373,9 @@ &mcu_i2c0 {
 	clock-frequency = <400000>;
 };
 
-&main_sdhci0 {
-	/* Unused */
-	status = "disabled";
-};
-
 &main_sdhci1 {
 	/* SD card */
+	status = "okay";
 	pinctrl-0 = <&main_mmc1_pins_default>;
 	pinctrl-names = "default";
 	disable-wp;
diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
index 02b7a559bdf21..3a8e6eb402448 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
@@ -333,6 +333,7 @@ exp2: gpio@22 {
 
 &main_sdhci0 {
 	/* eMMC */
+	status = "okay";
 	non-removable;
 	ti,driver-strength-ohm = <50>;
 	disable-wp;
@@ -340,6 +341,7 @@ &main_sdhci0 {
 
 &main_sdhci1 {
 	/* SD card */
+	status = "okay";
 	pinctrl-0 = <&main_mmc1_pins_default>;
 	pinctrl-names = "default";
 	disable-wp;
diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
index ed79ab3a32718..c46079fe4ed6e 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
@@ -665,6 +665,7 @@ main_sdhci0: mmc@4f80000 {
 		mmc-hs200-1_8v;
 		mmc-hs400-1_8v;
 		dma-coherent;
+		status = "disabled";
 	};
 
 	main_sdhci1: mmc@4fb0000 {
@@ -694,6 +695,7 @@ main_sdhci1: mmc@4fb0000 {
 		dma-coherent;
 		/* Masking support for SDR104 capability */
 		sdhci-caps-mask = <0x00000003 0x00000000>;
+		status = "disabled";
 	};
 
 	main_navss: bus@30000000 {
-- 
2.39.2


  parent reply	other threads:[~2023-08-02 20:53 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02 20:52 [PATCH 00/13] Another round of K3 DTSI disables Andrew Davis
2023-08-02 20:52 ` [PATCH 01/13] arm64: dts: ti: k3-j721e: Enable SDHCI nodes at the board level Andrew Davis
2023-08-07  5:22   ` Dhruva Gole
2023-08-02 20:52 ` [PATCH 02/13] arm64: dts: ti: k3-j7200: " Andrew Davis
2023-08-02 20:52 ` Andrew Davis [this message]
2023-08-02 20:53 ` [PATCH 04/13] arm64: dts: ti: k3-am65: Enable OSPI " Andrew Davis
2023-08-07  6:16   ` Dhruva Gole
2023-08-07 15:18     ` Andrew Davis
2023-08-08  5:27       ` Jan Kiszka
2023-08-08 13:16         ` Andrew Davis
2023-08-02 20:53 ` [PATCH 05/13] arm64: dts: ti: k3-j721e: " Andrew Davis
2023-08-02 20:53 ` [PATCH 06/13] arm64: dts: ti: k3-j7200: " Andrew Davis
2023-08-07  5:19   ` Dhruva Gole
2023-08-02 20:53 ` [PATCH 07/13] arm64: dts: ti: k3-am64: " Andrew Davis
2023-08-07  5:18   ` Dhruva Gole
2023-08-02 20:53 ` [PATCH 08/13] arm64: dts: ti: k3-j721e: Enable GPIO " Andrew Davis
2023-08-07  5:34   ` Dhruva Gole
2023-08-02 20:53 ` [PATCH 09/13] arm64: dts: ti: k3-j721s2: " Andrew Davis
2023-08-07  5:34   ` Dhruva Gole
2023-08-02 20:53 ` [PATCH 10/13] arm64: dts: ti: k3-j7200: " Andrew Davis
2023-08-07  5:38   ` Dhruva Gole
2023-08-07 15:28     ` Andrew Davis
2023-08-07 15:42       ` Nishanth Menon
2023-08-07 16:16         ` Andrew Davis
2023-08-02 20:53 ` [PATCH 11/13] arm64: dts: ti: k3-j721e: Enable TSCADC " Andrew Davis
2023-08-02 20:53 ` [PATCH 12/13] arm64: dts: ti: k3-am65: " Andrew Davis
2023-08-07  5:51   ` Dhruva Gole
2023-08-07 15:34     ` Andrew Davis
2023-08-02 20:53 ` [PATCH 13/13] arm64: dts: ti: k3-am64: " Andrew Davis
2023-08-07  5:41   ` Dhruva Gole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230802205309.257392-4-afd@ti.com \
    --to=afd@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®