From: Mario Limonciello <mario.limonciello@amd.com>
To: <jarkko@kernel.org>, <peterhuewe@gmx.de>
Cc: <linux-kernel@vger.kernel.org>, <linux-integrity@vger.kernel.org>,
<Jason@zx2c4.com>, <dragonn@op.pl>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH 1/3] tpm: Add a missing check for TPM_CHIP_FLAG_HWRNG_DISABLED
Date: Wed, 2 Aug 2023 20:50:13 -0500 [thread overview]
Message-ID: <20230803015015.915-2-mario.limonciello@amd.com> (raw)
In-Reply-To: <20230803015015.915-1-mario.limonciello@amd.com>
If the TPM is opted out of hwrng the error handling for
tpm_chip_register() needs to know this so it doesn't try to clean
up an uninitialized chip->hwrng.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/char/tpm/tpm-chip.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
index e904aae9771be..8f61b784810d6 100644
--- a/drivers/char/tpm/tpm-chip.c
+++ b/drivers/char/tpm/tpm-chip.c
@@ -629,7 +629,8 @@ int tpm_chip_register(struct tpm_chip *chip)
return 0;
out_hwrng:
- if (IS_ENABLED(CONFIG_HW_RANDOM_TPM) && !tpm_is_firmware_upgrade(chip))
+ if (IS_ENABLED(CONFIG_HW_RANDOM_TPM) && !tpm_is_firmware_upgrade(chip) &&
+ !(chip->flags & TPM_CHIP_FLAG_HWRNG_DISABLED))
hwrng_unregister(&chip->hwrng);
out_ppi:
tpm_bios_log_teardown(chip);
--
2.34.1
next prev parent reply other threads:[~2023-08-03 1:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 1:50 [PATCH 0/3] More changes related to TPM RNG handling Mario Limonciello
2023-08-03 1:50 ` Mario Limonciello [this message]
2023-08-03 8:59 ` [PATCH 1/3] tpm: Add a missing check for TPM_CHIP_FLAG_HWRNG_DISABLED Jarkko Sakkinen
2023-08-03 11:35 ` Mario Limonciello
2023-08-03 13:50 ` Jason A. Donenfeld
2023-08-04 22:52 ` Jarkko Sakkinen
2023-08-03 1:50 ` [PATCH 2/3] tpm: Add command line for not trusting tpm for RNG Mario Limonciello
2023-08-03 13:42 ` Jason A. Donenfeld
2023-08-03 1:50 ` [PATCH 3/3] tpm: Drop CONFIG_HW_RANDOM_TPM Mario Limonciello
2023-08-03 7:22 ` Paul Menzel
2023-08-03 9:03 ` Jarkko Sakkinen
2023-08-03 11:45 ` Mario Limonciello
2023-08-03 9:01 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803015015.915-2-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Jason@zx2c4.com \
--cc=dragonn@op.pl \
--cc=jarkko@kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®